Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:72206
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain zend.com from 74.125.82.172 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXZt7n8aqA=VrBKsqBzFiusGZP7aECPO-7xQher4+uVLWg@mail.gmail.com>
References: <CAGa2bXYHP5D70bDBhbWzE7-B0s2kgk7DmAZdFhXkLqMJQqKV5g@mail.gmail.com>
	<52EF4BF8.60005@sugarcrm.com>
	<CAGa2bXacCxnmcAPZjh-YgTNocMjEpu_Uoc4npfNcKVM2WA2Tow@mail.gmail.com>
	<CAGa2bXZt7n8aqA=VrBKsqBzFiusGZP7aECPO-7xQher4+uVLWg@mail.gmail.com>
Date: Tue, 4 Feb 2014 22:30:46 +0400
Message-ID: <CA+9eiLsC1nXFBBQ4bDAHNhMFJPg04UTgxG2jjAxdX4jTG7O0xA@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e0141a092bd708304f198d667
Subject: Re: [PHP-DEV] Declare minimum PHP version required?
From: dmitry@zend.com (Dmitry Stogov)

--089e0141a092bd708304f198d667
Content-Type: text/plain; charset=UTF-8

Hi Yasuo,

I don't think PHP needs new language constructs for assertions.
Actually, the code from your example may be implemented as two calls to
assert().

assert(extension_loaded('foo'), 'You need foo module');
assert(extension_loaded('bar'), 'You need bar module');

I think it's much clear then inventing new syntax.
With Joe's proposal these asserts might be completely eliminated.
And it's backward and forward compatible :)

BTW: I didn't follow all the discussion, so I may miss some points.

Thanks. Dmitry.





On Tue, Feb 4, 2014 at 1:08 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> Hi all,
>
> On Mon, Feb 3, 2014 at 7:55 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
>
>> We may extend declare() more. For example, loaded extensions.
>>
>> declare(module='pgsql,openssl');
>>
>> With this, we could eliminate code like
>>
>> if (!extension_loaded('foo')) {
>>   die('You need foo module');
>> }
>> if (!extension_loaded('bar')) {
>>   die('You need bar module');
>> }
>>
>> With opcache loaded extension check may be completely skipped.
>>
>> Evaluation at compile time and run time differs.
>>
>
> Similar thing could be achieved with new assert() w/o any overheads.
>
> https://wiki.php.net/rfc/expectations
>
> assert('version_compare(PHP_VERSION, "5.5.0", ">=")', 'You need PHP 5.5.0
> or later');
>
> Since assert() only accepts expression, it might be nice to have
>
> declare('assert') {
>   if (!extension_loaded('foo')) {
>      echo 'You need foo module';
>      return FALSE;
>   }
>   if (!extension_loaded('bar')) {
>      echo 'You need bar module';
>      return FALSE
>   }
>   return TRUE;
> }
>
> Usual PHP code might be easier to write complex assertion.
> It may be possible to share most of the new assertion code.
>
> Just an idea.
> What do you think Dmitry?
>
> Regards,
>
> --
> Yasuo Ohgaki
> yohgaki@ohgaki.net
>

--089e0141a092bd708304f198d667--