Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:72200
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.176 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <52F0FEE8.5010302@gmail.com>
References: <CAGa2bXbFk3+ScywpkeGcFUcmVvxLRHeWrdObvOshx6NjuB2YHw@mail.gmail.com>
	<52EDBB30.3070209@ajf.me>
	<CAGa2bXYMPM2+HinAANcDv2gvGNtfPHYFcKr=qrmXrsRPEbsiog@mail.gmail.com>
	<52EE1C2B.7030702@sugarcrm.com>
	<CAGa2bXYJAz8jMRmL4d9uHvspzg12km=ZosBtvqwywwc1wzmVuw@mail.gmail.com>
	<52EF50B6.1030404@sugarcrm.com>
	<CALwr1Gn95__kSkJfhseemSN=kugeymeW0-sT4yPC9_XBZp4VJg@mail.gmail.com>
	<CAGa2bXakngpviwqvbSKnMOtKMMtfwR5ZCfUx+4EDATv-2QqiwA@mail.gmail.com>
	<52F01654.6080903@sugarcrm.com>
	<CAGa2bXYkFPoUFgLT3DJr_Hq5yJjjJChXRn3hu-5q9hKndDsmpw@mail.gmail.com>
	<52F0FEE8.5010302@gmail.com>
Date: Tue, 4 Feb 2014 15:15:45 +0000
Message-ID: <CALwr1GnzhMfVH5_xDJDnfCofmB=CMhpn=5s938GrBKB0yMP03A@mail.gmail.com>
To: Rowan Collins <rowan.collins@gmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC] Improve HTML escape
From: padraic.brady@gmail.com (=?UTF-8?Q?P=C3=A1draic_Brady?=)

Hi Rowan,

On 4 February 2014 14:53, Rowan Collins <rowan.collins@gmail.com> wrote:
> I think part of the misunderstanding here is the distinction between "sho=
uld
> PHP support an appropriate escape mechanism for this situation?" and "sho=
uld
> the htmlentities() function be extended to be the appropriate escape
> mechanism for this situation?"
>
> The security requirement is for *users* to use appropriate escaping, and
> quoting, mechanisms for the output formats they use. The combination of
> quoted attributes and htmlspecialchars() with ENT_QUOTES is a secure
> escaping method, provided by the core of PHP.
>
> HTML5 *allows* users to use non-quoted attributes, but PHP does not
> currently have a built-in function which provides adequate escaping for t=
hat
> scenario. Such a function would need to do more than just escaping /, as
> others have pointed out; for instance, it would need to either escape,
> filter, or reject all forms of whitespace.
>
> I have no real opinion on what that function should be, except that I wil=
l
> personally never use it, because I will simply put quotes around my
> attributes and remove any need for it.

That's what we should be doing. Part of the concern with having a full
on unquoted attribute value escaping mechanism is what happens over
the course of an application's lifecycle. I'm absolutely of your
opinion, but others would argue that attribute escaping is defence in
depth against the day someone removes quotes without thinking. HTML5
has made that side of the fence more relevant.

If it were to be done, it would be a separate function other than
htmlspecialchars() which I assume is why htmlentities() as the local
greedy escaper makes an attractive carrier at face value. I don't
actually think it does fit there without redefining its purpose so a
separate function would be wiser.

Paddy

--
P=C3=A1draic Brady

http://blog.astrumfutura.com
http://www.survivethedeepend.com
Zend Framework Community Review Team
Zend Framework PHP-FIG Representative