Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:72197 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 91373 invoked from network); 4 Feb 2014 13:19:18 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 4 Feb 2014 13:19:18 -0000 Authentication-Results: pb1.pair.com smtp.mail=php@hristov.com; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=php@hristov.com; sender-id=unknown Received-SPF: error (pb1.pair.com: domain hristov.com from 91.196.124.214 cause and error) X-PHP-List-Original-Sender: php@hristov.com X-Host-Fingerprint: 91.196.124.214 more.superhosting.bg Linux 2.6 Received: from [91.196.124.214] ([91.196.124.214:55788] helo=more.superhosting.bg) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id EA/A1-17725-3D8E0F25 for ; Tue, 04 Feb 2014 08:19:16 -0500 Received: from [87.121.162.39] (port=44135 helo=[192.168.20.117]) by more.superhosting.bg with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.80.1) (envelope-from ) id 1WAfuC-003AqK-Ex for internals@lists.php.net; Tue, 04 Feb 2014 15:19:12 +0200 Message-ID: <52F0E8CF.7090501@hristov.com> Date: Tue, 04 Feb 2014 15:19:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: internals@lists.php.net References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - more.superhosting.bg X-AntiAbuse: Original Domain - lists.php.net X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - hristov.com X-Get-Message-Sender-Via: more.superhosting.bg: authenticated_id: php@hristov.com X-Source: X-Source-Args: X-Source-Dir: Subject: Re: [PHP-DEV] 64 bit RFC, #2 and #3 yes From: php@hristov.com (Andrey Hristov) On 1.02.2014 14:30, Anatol Belski wrote: > Hi, > > as the concerns on the BC breach by zpp and macros changes are huge, we've > invented the below to make the essential change only visible. > > This branches have zpp and macros change reverted (like #2 and #3 had > resulted yes), only the necessary 64 improvement is in place. > > PHP core, zpp and macros reverted to the state of mainstream > https://github.com/weltling/php-src/tree/str_size_and_int64_old_names > > Diff of the branch with old names to master > http://belski.net/phpz/str_size_and_int64_old_names.diff > > > An extension ported and fully worky with 5.3/4/5 and str_size_and_int64 > branch, diff > https://github.com/weltling/phurple/compare/str_size_and_int64 > > The same ext how it looks now (not using the new zpp placeholders) > https://github.com/weltling/phurple > > > A sample extension generated with ext_skel from str_size_and_int64 branch > with several usage examples, worky also wit h5.3/4/5 > https://github.com/weltling/str_size_and_int64_example/blob/master/str_size_and_int64.c#L47 > > The sample ext diff to the current mainstream base > https://github.com/weltling/str_size_and_int64_example/compare/str_size_and_int64_revert > > > Were this an acceptable tradeoff for this RFC to make it, one could still > decide it in favor of 5.6. The worries and wishes are not reasonless, > which is clear. However I think to strike a compromise is important to > keep balance. > > Regards > > Anatol > > > > I saw 2 problems with the patch, in mysqlnd. After 2 instances I stopped reading but a parameter of type uint is being declared as php_int_t, a flag variable. Andrey