Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:72109
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.48 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CAESVnVokb1EJrw=Kn_Cc4zVBx4tj-xrBkWrWj2VeYg2_aUFs7Q@mail.gmail.com>
References: <CAGa2bXYHP5D70bDBhbWzE7-B0s2kgk7DmAZdFhXkLqMJQqKV5g@mail.gmail.com>
 <CAESVnVokb1EJrw=Kn_Cc4zVBx4tj-xrBkWrWj2VeYg2_aUFs7Q@mail.gmail.com>
Date: Tue, 4 Feb 2014 04:46:22 +0900
Message-ID: <CAGa2bXYwAeG7sF+3wJLsLYpn4hkh=vBWYLK+zkKFyM4y3F9t0A@mail.gmail.com>
To: Sara Golemon <pollita@php.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1136c742a5938a04f185c98c
Subject: Re: [PHP-DEV] Declare minimum PHP version required?
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a1136c742a5938a04f185c98c
Content-Type: text/plain; charset=UTF-8

Hi Sara,

On Tue, Feb 4, 2014 at 3:14 AM, Sara Golemon <pollita@php.net> wrote:

> On Sun, Feb 2, 2014 at 10:58 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> > I thought it might be good for us to have declaring minimum PHP version
> > required to execute script.
> > http://jp1.php.net/manual/en/control-structures.declare.php
> >
> > Something like
> > <?php
> > declare(php_version>='5.6.0');
> > // or PHP_VERSION_ID? using = as minimum as it could be a little faster
> > // and no change in declare() syntax.
> > declare(php_version=50600);
> >
> While I like it from a formality stand-point, I have to agree with
> Stas.  The is entirely doable as PHP code right now.  Include time IS
> execute time.  And if you're concerned with a single integer compare
> in your perf analysis, you're probably worried about the wrong thing.


I may be worried to much, but I don't like run time environment checks
which evaluated over and over. There are many codes that checks PHP
version, loaded extension, library version, etc to make sure code works as
it should be. Perhaps, more generic form might be better

declare('requirements') {
  if (version_compare(PHP_VERSION, '5.6.0', '<')) {
     echo 'You need PHP 5.6.0 or later';
     return FALSE;
  }
  if (!extension_loaded('foo')) {
     echo 'You need foo extension';
     return FALSE;
  }
  // and so on
  return TRUE;
}

for example.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a1136c742a5938a04f185c98c--