Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:72093
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.192.170 as permitted sender)
MIME-Version: 1.0
Sender: php@golemon.com
In-Reply-To: <CAGa2bXYHP5D70bDBhbWzE7-B0s2kgk7DmAZdFhXkLqMJQqKV5g@mail.gmail.com>
References: <CAGa2bXYHP5D70bDBhbWzE7-B0s2kgk7DmAZdFhXkLqMJQqKV5g@mail.gmail.com>
Date: Mon, 3 Feb 2014 10:14:56 -0800
Message-ID: <CAESVnVokb1EJrw=Kn_Cc4zVBx4tj-xrBkWrWj2VeYg2_aUFs7Q@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] Declare minimum PHP version required?
From: pollita@php.net (Sara Golemon)

On Sun, Feb 2, 2014 at 10:58 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> I thought it might be good for us to have declaring minimum PHP version
> required to execute script.
> http://jp1.php.net/manual/en/control-structures.declare.php
>
> Something like
> <?php
> declare(php_version>='5.6.0');
> // or PHP_VERSION_ID? using = as minimum as it could be a little faster
> // and no change in declare() syntax.
> declare(php_version=50600);
>
While I like it from a formality stand-point, I have to agree with
Stas.  The is entirely doable as PHP code right now.  Include time IS
execute time.  And if you're concerned with a single integer compare
in your perf analysis, you're probably worried about the wrong thing.

-Sara