Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:71806
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
Message-ID: <54f2a1a9a9bd0277e0690c7b5f3837ce.squirrel@webmail.klapt.com>
In-Reply-To: <52EAADBB.7080408@marc-bennewitz.de>
References: <e0681b3331094323d383a048471790f8.squirrel@webmail.klapt.com>
    <52EAADBB.7080408@marc-bennewitz.de>
Date: Thu, 30 Jan 2014 22:52:22 +0100
To: "Marc Bennewitz" <php@marc-bennewitz.de>
Cc: internals@lists.php.net
User-Agent: SquirrelMail/1.5.2 [SVN]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [VOTE] 64 bit platform improvements for string length
 and integer
From: anatol.php@belski.net ("Anatol Belski")

Hi Marc,

thanks for the comments.
On Thu, January 30, 2014 20:53, Marc Bennewitz wrote:
> Hi Anatol,
>
>
> As of renaming LONG to INT there is one small inconsistence in the RFC:
> - ZEND_STRTOL/ZEND_STRTOUL should be ZEND_STRTOI/ZEND_STRTOUI
Sounds logic, as despite ZEND_STRTOL maps strtol(), zend_int_t for
instance also not necessarily 'int' literally. Just that the RFC is
already being voted ...

> - SIZEOF_ZEND_INT should be ZEND_INT_SIZEOF to be consistent with
> ZEND_INT_MAX/ZEND_INT_MIN/ZEND_UINT_MAX
>
This descends from things like SIZEOF_LONG and so on, so completely legit
for a C source.

> And in my opinion if we go to rename LONG to INT with BC we should also
> rename DOUBLE to FLOAT :)
>
Well, total renames was not the primary goal of this RFC. The renames
suggested are to reflect what's going on in the patch and to break
compilation with incompatible sources. Such topic asks for a new RFc :)

Regards

Anatol