Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:71787
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.49 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <7732132.fl6VoBGJan@rofl>
References: <CAGa2bXZEXx7H+atr3LK8OLLQGSd9a-6+Gey+RhPwP0d7EvTBmw@mail.gmail.com>
 <CAJ26g5TnAqeU4mpSfav7j+CDwBrfL_XRuzNrXpBuc6xrN14ewA@mail.gmail.com>
 <CAGa2bXY+9sEnBTi2s9kXDWSAONGvMywGoxRcOEyrFG5ODoKTsw@mail.gmail.com> <7732132.fl6VoBGJan@rofl>
Date: Thu, 30 Jan 2014 16:39:28 +0900
Message-ID: <CAGa2bXaao+H81C230nKQHuBCLOmL_R4hxDB66C0V98spMk0M3A@mail.gmail.com>
To: Patrick Schaaf <php@bof.de>
Cc: internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c36c50a6267b04f12b2a53
Subject: Re: [PHP-DEV] Re: [VOTE] Introduce session.lock, session.lazy_write
 and session.lazy_destory
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a11c36c50a6267b04f12b2a53
Content-Type: text/plain; charset=UTF-8

Hi Patrick,

On Thu, Jan 30, 2014 at 4:30 PM, Patrick Schaaf <php@bof.de> wrote:

> I don't see that. You mean by the call to ps_files_close() within
> ps_files_open(), and that close() call dropping the lock? That is
> conditional
> on either data->fd < 0 (no file open, just a superfluous call to
> ps_file_close()), or key != lastkey (and then a _different_ file will be
> opened and locked for writing).
>

Next request may read closed session data which is no longer valid.
When it is destroyed or regenerated session with new code, it will be
handled by
lazy_destroy. So it's not a problem.

When session is not destroyed or regenerated, close call in PS_WRITE
unlocks
file then next request starts reading it. This could happen before writing
data by
previous request.

I don't have access to the code right now, so I have to double check though.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a11c36c50a6267b04f12b2a53--