Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:71784
Return-Path: <php@bof.de>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 61542 invoked from network); 30 Jan 2014 07:30:42 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 30 Jan 2014 07:30:42 -0000
Authentication-Results: pb1.pair.com smtp.mail=php@bof.de; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=php@bof.de; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain bof.de designates 80.242.145.70 as permitted sender)
X-PHP-List-Original-Sender: php@bof.de
X-Host-Fingerprint: 80.242.145.70 mars.intermailgate.com  
Received: from [80.242.145.70] ([80.242.145.70:41297] helo=mars.intermailgate.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 46/F3-42724-0AFF9E25 for <internals@lists.php.net>; Thu, 30 Jan 2014 02:30:41 -0500
Received: (qmail 25953 invoked by uid 1009); 30 Jan 2014 08:30:37 +0100
Received: from 213.135.15.139 by mars (envelope-from <php@bof.de>, uid 89) with qmail-scanner-1.25-st-qms 
 (clamdscan: 0.96.2/18413. spamassassin: 3.3.1. perlscan: 1.25-st-qms.  
 Clear:RC:0(213.135.15.139):SA:0(-1.1/10.0):. 
 Processed in 0.550335 secs); 30 Jan 2014 07:30:37 -0000
X-Spam-Status: No, hits=-1.1 required=10.0
X-Antivirus-MYDOMAIN-Mail-From: php@bof.de via mars
X-Antivirus-MYDOMAIN: 1.25-st-qms (Clear:RC:0(213.135.15.139):SA:0(-1.1/10.0):. Processed in 0.550335 secs Process 25938)
Received: from unknown (HELO rofl.localnet) (gmail@bof.de@213.135.15.139)
  by mars.intermailgate.com with AES256-SHA encrypted SMTP; 30 Jan 2014 08:30:36 +0100
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: internals <internals@lists.php.net>
Date: Thu, 30 Jan 2014 08:30:35 +0100
Message-ID: <7732132.fl6VoBGJan@rofl>
User-Agent: KMail/4.11.5 (Linux/3.13.0-k10-bof; KDE/4.11.5; x86_64; ; )
In-Reply-To: <CAGa2bXY+9sEnBTi2s9kXDWSAONGvMywGoxRcOEyrFG5ODoKTsw@mail.gmail.com>
References: <CAGa2bXZEXx7H+atr3LK8OLLQGSd9a-6+Gey+RhPwP0d7EvTBmw@mail.gmail.com> <CAJ26g5TnAqeU4mpSfav7j+CDwBrfL_XRuzNrXpBuc6xrN14ewA@mail.gmail.com> <CAGa2bXY+9sEnBTi2s9kXDWSAONGvMywGoxRcOEyrFG5ODoKTsw@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [PHP-DEV] Re: [VOTE] Introduce session.lock, session.lazy_write and session.lazy_destory
From: php@bof.de (Patrick Schaaf)

Hi Yasuo,

On Thursday 30 January 2014 16:17:58 Yasuo Ohgaki wrote:
> 
> I also notice other issue when closely looking at current code.
...
> 
> However, when write() is called, it always close opened fd to address
> changed session ID.

I don't see that. You mean by the call to ps_files_close() within 
ps_files_open(), and that close() call dropping the lock? That is conditional 
on either data->fd < 0 (no file open, just a superfluous call to 
ps_file_close()), or key != lastkey (and then a _different_ file will be 
opened and locked for writing).

best regards
  Patrick