Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:71739
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.170 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <52E9469D.6000302@sugarcrm.com>
References: <CAGa2bXZJoyV+9qN6v8j3+vHexoqDtHR4cZkgdtdc1GpVkDaD9w@mail.gmail.com>
 <CAFMT4Npqop1AZRSN3whd7k4YUU1yhfQ50+MXnZSfb5+_FcoeeQ@mail.gmail.com>
 <4ED7146272E04A47B986ED49E771E347BBC71EE3A9@Ikarus.ameusgmbh.intern> <52E9469D.6000302@sugarcrm.com>
Date: Thu, 30 Jan 2014 03:51:21 +0900
Message-ID: <CAGa2bXYLEHuUSB6ryfbkEirgWi7CLZTUhZ-t4z0=qCFzSRuUQA@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: Christian Stoller <stoller@leonex.de>, Levi Morrison <morrison.levi@gmail.com>, 
	Larry Garfield <larry@garfieldtech.com>, internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c23404b3467404f1206f41
Subject: Re: [PHP-DEV] Re: [PHP6] Function name consistency
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a11c23404b3467404f1206f41
Content-Type: text/plain; charset=UTF-8

Hi Stas,

On Thu, Jan 30, 2014 at 3:21 AM, Stas Malyshev <smalyshev@sugarcrm.com>wrote:

> > Compare: `$str = str_replace('-', '_', $str);`
> >
> > To:      `$str = $str->replace('-', '_');`
> >
> > Or: `$keys = array_keys($array);`
> >
> > To: `$keys = $array->keys();`
> >
> > I think it looks a lot cleaner, self-explaining, shorter, and if you
> > are used to write OOP, it fits better to the rest of your code.
>
> I think it has very little difference and entirely a matter of personal
> taste. But the thing is - nobody prevents anybody from writing an
> extension that does string ops or array ops as an object. Yet it did not
> happen in last 10 years, AFAIK.


It was said and didn't happen...
I would like to make session/pgsql a class some day. I don't know
when it will be, since I'm satisfied with current implementation.

Besides OO API, we should keep function API. It may be confusing
to users if OO and function name differs.

It may be good to add proper aliases now and when it is needed,
so that we don't have

const zend_function_entry server_additional_functions[] = {
    PHP_FE(cli_set_process_title,        arginfo_cli_set_process_title)
    PHP_FE(cli_get_process_title,        arginfo_cli_get_process_title)
    PHP_FE(apache_request_headers, arginfo_no_args)
    PHP_FE(apache_response_headers, arginfo_no_args)
    PHP_FALIAS(getallheaders, apache_request_headers, arginfo_no_args)
    {NULL, NULL, NULL}
};

this kind of naming anymore.

I understand reason why, but *new* 'apache_*()' function in cli server
does not make much sense to me. For this case, I suggest 'sapi_*()'
or 'http_*()' as main name and others as aliases.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a11c23404b3467404f1206f41--