Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:71608
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.177 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CAGa2bXaHOEr3pKL24t4fH0atQkNk-U7_XepdC-STNS=rhB206g@mail.gmail.com>
References: <CAGa2bXY0tONu2WLzv-KkJSiHW2x-XZT=8ZdNSeDep3SArcqW_A@mail.gmail.com>
 <CAGa2bXZ0KH2A9BLo60HjKqMRJ10D9fLxs8CYkbt786iGNMcXow@mail.gmail.com>
 <CAGa2bXbKAquga7QSM96F8odWPbm2ybREOCbTRhqsXcUDubSxyQ@mail.gmail.com>
 <52E4A992.1050902@sugarcrm.com> <CAGa2bXaqsZDPUJ5p-AwKp8t9VX6Q3=SnMCN7fCsx7N1uUwnv0g@mail.gmail.com>
 <52E56CD1.2060803@sugarcrm.com> <CAGa2bXaHOEr3pKL24t4fH0atQkNk-U7_XepdC-STNS=rhB206g@mail.gmail.com>
Date: Mon, 27 Jan 2014 07:31:31 +0900
Message-ID: <CAGa2bXbZLjWisfn5p34V-nGX5AV8a==aiDwuF-_SQrT8Gyu+4g@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c23c08920dea04f0e72952
Subject: Re: [PHP-DEV] Re: [VOTE] Default character encoding
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a11c23c08920dea04f0e72952
Content-Type: text/plain; charset=UTF-8

On Mon, Jan 27, 2014 at 7:18 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> On Mon, Jan 27, 2014 at 5:15 AM, Stas Malyshev <smalyshev@sugarcrm.com>wrote:
>
>> > Typical configuration works, but it's better to be resolved soon bugs.
>> > I don't have much time now, so I hope someone has time to take care...
>>
>> Well, we can not merge a patch that segfaults. So until this is fixed,
>> that patch is a no go.
>
>
> The patch is not causing segfaults.
>
> Zend engine is segfaulting for zend_multibyte tests.
> It's a separate issue. You'll see segfaults in 5.4 and up without
> my patch.
>
> I've merged zend_multibyte tests fixes already. That's the reason why you
> see failing tests on 5.4 and up.
>
> It's a different issue and if nobody is willing to fix. I'll fix
> zend_multibyte
> next month.
>


For the record, I committed this patch to 5.4 and up.
As you can see, the patch is simply re-enabled tests for 5.4 and up.
(Note: there is no mbstring.script_encoding INI for 5.4 and up. It's
removed.)

The segfaults of zend engine are irrelevant for this proposal.

commit e769c96a1102f33e5783c35b7a7eedf5d81be7b9
Author: Yasuo Ohgaki <yohgaki@php.net>
Date:   Sun Jan 19 13:28:48 2014 +0900

    Enable zend.multibyte tests. Tipcal configuration works, but most tests
fail.

diff --git a/ext/mbstring/tests/zend_multibyte-01.phpt
b/ext/mbstring/tests/zend_multibyte-01.phpt
index d96e0f0..f2403ab 100644
--- a/ext/mbstring/tests/zend_multibyte-01.phpt
+++ b/ext/mbstring/tests/zend_multibyte-01.phpt
@@ -1,14 +1,9 @@
 --TEST--
 zend multibyte (1)
 --SKIPIF--
-<?php
-ini_set("mbstring.script_encoding","SJIS");
-if (ini_set("mbstring.script_encoding","SJIS") != "SJIS") {
-       die("skip zend-multibyte is not available");
-}
-?>
 --INI--
-mbstring.script_encoding=Shift_JIS
+zend.multibyte=On
+zend.script_encoding=Shift_JIS
 mbstring.internal_encoding=Shift_JIS
 --FILE--
 <?php

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a11c23c08920dea04f0e72952--