Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:71467
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.173 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <alpine.DEB.2.10.1401231227590.6067@whisky.home.derickrethans.nl>
References: <CAESVnVq3=+_N-c5e1n==c=w9Og82FM24pBqJJt66yS-Swru0TA@mail.gmail.com>
 <2D2D996C-9455-4DD1-9669-90AFAF591E32@strojny.net> <CAGa2bXZ_8non-C8bpoPXvVFCgmPcEZ-RAm3U6wFJ+FGgw8aW=w@mail.gmail.com>
 <alpine.DEB.2.10.1401221933540.6067@whisky.home.derickrethans.nl>
 <CAGa2bXbs=J3AM7vifGrDCZYXji-bNvbnkNqCzjQXPJGkvAajNg@mail.gmail.com> <alpine.DEB.2.10.1401231227590.6067@whisky.home.derickrethans.nl>
Date: Fri, 24 Jan 2014 06:51:28 +0900
Message-ID: <CAGa2bXapauJ1-ucFvmrxz7cdrjXLGv0o8E7NDS7ihrFEQMZGDA@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: Lars Strojny <lars@strojny.net>, Sara Golemon <pollita@php.net>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11381b4ec7812004f0aa40fe
Subject: Re: __set_state (Was: Re: [PHP-DEV] [RFC] __debug_info())
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a11381b4ec7812004f0aa40fe
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Derick,

On Thu, Jan 23, 2014 at 8:30 PM, Derick Rethans <derick@php.net> wrote:

> > > > Could anyone add __setState() for 5.6?
> > >
> > > Why would you want to do that? If at all, all the *newer* methods
> > > should be __debug_info etc. __set_state was first and changing it to
> > > __setState() would mean that var_export'ed() variables in < PHP 5.6
> > > would now no longer work? Or the other way around? It's a cosmetic
> > > change that helps nobody=E2=80=94just like renaming other standard fu=
nctions
> > > to make them more "organised".
> >
> > I mean add alias for __set_state() to keep consistent names.
> > __set_state() should be there very long time or forever for
> > compatibility.
>
> You seem to misunderstand what __set_state() is for. It is for reliably
> representing a value so that you can "include" it's contents with
> var_export(). If 5.6 would suddenly start spitting out
> Class::__setState() instead of Classs::__set_state() then older PHP
> versions can't parse/include that outputted data anymore.
>

I have to check code, but don't we have options for this?
We may use __set_state() for var_export and still have alias as __setState.
People are using var_export exchange PHP data, so we should be careful.
I agree this.

 > It's small cosmetic change, but it would assure PHP to be a good
> > language to learn in the future. IMHO.
>
> But it makes as much sense as adding a str_len
>

I understand both opinion, strlen could be str_len. Other str function may
be reamed.

Some names are easy to decide, some are not. We may have list of votes
for these. I'll make list after 5.6 release :)

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a11381b4ec7812004f0aa40fe--