Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:71426
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.46 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CA+9eiLvhRqFAunM8GCpqE5ja2jXKCzFMKdtF0NkBT11nu=36MQ@mail.gmail.com>
References: <fa05c43bc2fff5420759e05dee19c99f.squirrel@webmail.klapt.com>
	<CAF+90c8mDBqe+E=cWxpD-U48Ho0QV3iHiwS9pOSEbUn_uZTVnQ@mail.gmail.com>
	<CA+9eiLvhRqFAunM8GCpqE5ja2jXKCzFMKdtF0NkBT11nu=36MQ@mail.gmail.com>
Date: Thu, 23 Jan 2014 10:13:13 +0100
Message-ID: <CAEZPtU7-mBoXcsvXQvD42uG58KKKLY3TJL=aV5uqcGEFhE3PKQ@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: Nikita Popov <nikita.ppv@gmail.com>, Anatol Belski <ab@php.net>, 
	PHP Developers Mailing List <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC] 64 bit platform improvements for string length
 and integer
From: pierre.php@gmail.com (Pierre Joye)

On Thu, Jan 23, 2014 at 9:42 AM, Dmitry Stogov <dmitry@zend.com> wrote:
> I completely agree with Nikita.
> Why to rename LONG->INT STRLEN->STRSIZE in thousands places?
> Why not just define zend_long and zend_ulong to be 64-bit on 64-bit
> platforms and use them instead of int, ulint, zend_int, zend_uint, long,
> ulong where it's necessary.
>
> Anatol, I understood your point about catching incompatibility code at
> compile-time, but I'm not sure if the new features cost such huge code base
> changes.

To catch 64bit issues at compile is immensely valuable. We had so many
issues in the past, some of them leading to security issues. It is
also a one time job, with a little extra effort for  two years.
Besides the portability improvements, code review and correctness is
one of the goal of this RFC. I can't remember to know any widely known
and sane project relying on on other type for buffer length. PHP does
not have to be different :)

> 1) 64-bit integers on Windows (they are already 64-bit on other systems)

Almost all :)

> 2) 64-bit string length. I don't think many people are interested in that.
> Fortunately, the patch doesn't change the zval size, so it shouldn't make a
> lot of harm. However, usage of "zend_size_t" instead of "int" is a bit
> annoying. I would change it into the same "zend_long" or "zend_ulong".

It is not about being interested but preventing many security issues
as well, by default. The large buffer availability is a good side
effect. The implementation correctness is also drastically improved in
this case.

Cheers,
-- 
Pierre

@pierrejoye | http://www.libgd.org