Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:71263
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 66.111.4.25 as permitted sender)
Message-ID: <1390099947.26938.72538325.1FDD1F20@webmail.messagingengine.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>, internals@lists.php.net
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain
In-Reply-To: <52DB310A.9040506@sugarcrm.com>
References: <1390082096.14862.72482025.5D36E64F@webmail.messagingengine.com>
 <52DB2E4D.8000009@sugarcrm.com>
 <1390096353.18659.72527933.474C16A5@webmail.messagingengine.com>
 <52DB310A.9040506@sugarcrm.com>
Date: Sat, 18 Jan 2014 18:52:27 -0800
Subject: Re: [PHP-DEV] Bug 62479
From: willfitch@php.net (Will Fitch)

Hi!

On Sat, Jan 18, 2014, at 05:57 PM, Stas Malyshev wrote:
> Hi!
> 
> > I see no comments from you.  The only response I've seen from you was
> > your asking me if the patch was ready (in comments on the bug).  Can you
> > please elaborate?
> 
> The comment is right in the patch:
> https://github.com/willfitch/php-src/commit/06170d344f6b3148d505afd8ae952d3439de9005
> but I have already repeated it here - from the code it follows that if
> the password starts with ' or ends with ', it will not be encoded. Is
> this correct behavior?

My apologies for not seeing the comment in Github. I didn't get notified
by email, so I didn't look.  Starting with a quote would technically
work, but ending would not (assuming you're throwing the password in
from the DSN and not parameter).  However, I'm not sure this edge is
worth the CPU cycles for checking.  Then again, I didn't expect to have
a bug where single quotes are part of the password, so there's always a
surprise.

If you feel it's worth the overhead, I'll add in the additional logic.

> -- 
> Stanislav Malyshev, Software Architect
> SugarCRM: http://www.sugarcrm.com/
> (408)454-6900 ext. 227