Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:71173
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.176 as permitted sender)
MIME-Version: 1.0
Sender: are.you.winning@gmail.com
In-Reply-To: <93EFD00C-017E-4DBE-A9A4-AEA40109D354@strojny.net>
References: <CABDNdAGCH5i9-=4Ys1CXeNaGWGmX=mkTiq0b7BbUKtBPdQ9XVg@mail.gmail.com>
	<93EFD00C-017E-4DBE-A9A4-AEA40109D354@strojny.net>
Date: Thu, 16 Jan 2014 10:04:42 +0000
Message-ID: <CAGAGxbba6imSY+wRNaz4z3N8q51FzD5kTXpUCMCj80XpKZwYQQ@mail.gmail.com>
To: Lars Strojny <lars@strojny.net>
Cc: Philip Sturgeon <pjsturgeon@gmail.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] Introducing "Array Of" RFC
From: daverandom@php.net (Chris Wright)

On 15 January 2014 21:24, Lars Strojny <lars@strojny.net> wrote:
> Given I hint for Foo[], and pass [new Foo(), new Bar(), new Baz()] it will
> only inform me about Bar violating Foo. I would like to have a more descriptive
> error message that contains both Bar and Baz.

While I see where you're coming from with this, it's non-trial to
implement this in a sane way, both in code and to handle every
possible scenario in a logical way. Suppose I pass an array or 10000
objects which instances of 10000 different classes which do not
satisfy the type hint? I guess you'd want to do something like

<= 3 offenders - give their class names and indices
> 3 offenders - give an error along the lines "passed array elements are completely wrong" (or maybe report first three and append a "and other errors")

...but IMO the complexity this would add is not worth the effort. From
a consistency point of view it should just use the same error logic as
the shiny new variadics feature - which also bails out at the first
offender.

Thanks, Chris