Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:71119
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.177 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CAGa2bXb=qA=fdfbXtvq0nqvQuoBxYrJQTvU3J380=aMas1UQ5A@mail.gmail.com>
References: <CAGa2bXb=qA=fdfbXtvq0nqvQuoBxYrJQTvU3J380=aMas1UQ5A@mail.gmail.com>
Date: Tue, 14 Jan 2014 11:58:38 +0900
Message-ID: <CAGa2bXbbYkVOeDYWZa8w0AmLuziU2U+=k54bQHtxrCAaEy1z+w@mail.gmail.com>
To: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b3a84c210225604efe5610a
Subject: Re: PostgreSQL lo_lseek64()/etc support.
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--047d7b3a84c210225604efe5610a
Content-Type: text/plain; charset=UTF-8

On Mon, Jan 13, 2014 at 6:48 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> PostgreSQL 9.3 has support for 2GB+ large object support via
> new APIs. e.g. lo_lseek64(), lo_tell64()
>
> I've made patch that supports new 64bit large object APIs.
>
> https://gist.github.com/yohgaki/35b12a48ac6332633e60
>
> It adds new functions pg_lo_seek64(), pg_lo_tell64, pg_lo_truncate64().
> However, these new functions are not mandatory. It could be made to use
> php.ini setting which specifies libpq API is used by
> pg_lo_seek()/pg_lo_tell()/
> pg_lo_truncate().
>
> libpq's lo_lseek(), lo_tell() will be legacy and unused APIs in the long
> run.
> Therefore, it may be better to change API to be used according to php.ini
> setting. e.g. When pgsql.server_version=9.3 (or greater), use lo_*64()
> if it's available.
>
> Pros.
>  - No additional API exposed.
>  - No legacy API in the future.
>  - Old code can extend capability w/o code change.
>  - No additional user code is required to detect and switch API.
>  - No query is required to detect PostgreSQL server version when
>    php.ini based switch is used.
>
> Cons.
>  - Additional php.ini that specifies server version.
>
> Even though I've made patch that simply exposes new libpq APIs,
> patch that has php.ini switch is better. IMO.
>
> Any comments?
> If there aren't any objections, I'll create and commit patch that uses
> php.ini to change pg_lo_*() behavior.
>
> Note about libpq's lo_*64() APIs:
> These APIs returns -1(failure) always if server version is less than
> PostgreSQL 9.3.
>
> Note for 32bit platforms:
> Since PHP int is 32bit int, 64bit support could be used but it's limited
> by 32bit int.
>

I've made better patch for this.

https://gist.github.com/yohgaki/dbae821c49d6531d9345

It does not require additional php.ini and use proper API for
large object. (It has 32bit int issue on 32bit platforms, but this is
different issue like file IO)

Any comments?

I'll test it against older PostgreSQL and if there aren't problem,
I'll commit this to 5.6 and up in a few days.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--047d7b3a84c210225604efe5610a--