Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:71107
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.73.107 as permitted sender)
Message-ID: <8c21685f662d0d716e44055e55fd686c.squirrel@webmail.klapt.com>
In-Reply-To: <f3d0ad6a6b6575da7929efc71116eaa6.squirrel@webmail.klapt.com>
References: <fa05c43bc2fff5420759e05dee19c99f.squirrel@webmail.klapt.com>
    <CAF+90c8mDBqe+E=cWxpD-U48Ho0QV3iHiwS9pOSEbUn_uZTVnQ@mail.gmail.com>
    <a0a503d9f023c87e79ad1bb877d64789.squirrel@webmail.klapt.com>
    <CADNQb0VaDeT==WAcN_rsyp61L4bf14VvcmgpXL70E5i2T5G97g@mail.gmail.com>
    <f3d0ad6a6b6575da7929efc71116eaa6.squirrel@webmail.klapt.com>
Date: Mon, 13 Jan 2014 04:37:04 +0100
To: "Anatol Belski" <ab@php.net>
Cc: "Hannes Magnusson" <hannes.magnusson@gmail.com>,
 "Nikita Popov" <nikita.ppv@gmail.com>,
 "Derick Rethans" <derick@php.net>,
 "PHP Developers Mailing List" <internals@lists.php.net>
Reply-To: "Anatol Belski" <ab@php.net>
User-Agent: SquirrelMail/1.5.2 [SVN]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [RFC] 64 bit platform improvements for string length
 and integer
From: ab@php.net ("Anatol Belski")

Hi,

On Sat, January 11, 2014 04:34, Anatol Belski wrote:

> About zpp I've got a click - the compatibility with 5.x can be integrated
>  into zpp itself in 6.x. I mean look here
> http://git.php.net/?p=php-src.git;a=blob;f=Zend/zend_API.c;hb=refs/heads/
> str_size_and_int64#l326 - 'l' and 'L' was replaced with 'i' and 'I', but
> nothing prevents to turn those formats as aliases in 6.x. That way 'l' and
> 'i' and another pairs
> will do the same thing, new implementations can use clean semantics, and
> the old formats can be removed after 5.x EOL. This solution however won't
>  force the new semantic.
>
> Another way i could suggest for zpp is similarly to docrefs using a
> wrapper like zend_parse_parameters_comp(), which would replace new for old.
> Still not very nice but would guarantee semantically correct formats.

Here's the first worky header and replacement tool variant
http://git.php.net/?p=php-src.git;a=tree;f=compat;h=166ac434f01d38119eb12160f2513cfe99c39b42;hb=refs/heads/str_size_and_int64
. The PECL readme is in progress.

After trying some extensions I come to conclusion, that both of the
compatibility variants above are not good.

The first one with aliasing gives no good feeling, after trying in
practice - it might lead even to more confusion.
The second with the *_compat() - technically it's a bit rubbish, as the
specs are literals saved in the readonly TEXT segment, so replacing on the
fly costs some allocations on the heap. While still doable, the overhead
isn't worthy.

The variant I would suggest is using ternary operator, passing both old
and new style, like

COMPAT ? "lLps" : "iIPS"

While being simple, this makes the difference good visible, so is clear.
Comparing with the breakages we had in the past like literals between 5.3
and 5.4, syntactically no #ifdef needed as it's done in place.

For the printf formats I'd suggest using ZEND_INT_FMT macros concatenated
with the format literal. The quirk here is the same as it's in the TEXT
segment. But still, with this solution no #ifdef is needed.

The latter solution suggestions are much simpler and don't need to be done
much, what do you think?

The readme is still in progress, however if curious, the current
replacement tool and header already do the job, so one can try the porting
with minimal effort.

Regards

Anatol