Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:71063 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 93995 invoked from network); 11 Jan 2014 15:05:05 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 11 Jan 2014 15:05:05 -0000 Authentication-Results: pb1.pair.com header.from=jakub.php@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=jakub.php@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.177 as permitted sender) X-PHP-List-Original-Sender: jakub.php@gmail.com X-Host-Fingerprint: 209.85.216.177 mail-qc0-f177.google.com Received: from [209.85.216.177] ([209.85.216.177:48862] helo=mail-qc0-f177.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 63/33-10544-0AD51D25 for ; Sat, 11 Jan 2014 10:05:04 -0500 Received: by mail-qc0-f177.google.com with SMTP id i8so1463488qcq.22 for ; Sat, 11 Jan 2014 07:05:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=B3aozWomWaIqT4tzS+aiUpavGV39iFvg5XPgRpN26wo=; b=Ow1LMIpQ/todzopRjJrywOhXhZ1vhDhidx1st1is0F1imFpyIRIXaLmzy9lcOY2V95 nsmi6jA76rzXb0KLd+fHF73GCJ8XW2fStm1SVbD85ARaafHzgzNsdDqmWHlEK7Bo4yXp 4IUVSbjyDCgRAQVQF5SHGmGFOLOOepnhz1R5Hm7oqkdhEPm1k3al9Zmhz9fqM+s9zn/W P+03BJ0pyDcydnE1jJGRrtiFvzgN+oXWUYuI+SjJHct+pEYVsLobVT3CCyjQFxvM9caS +yvaeQTAh85BrlAEecZDZwawZlv1jMPg084qhm8wVoX+h/GI2bvcGEISgdpfleRarPik Yghg== MIME-Version: 1.0 X-Received: by 10.224.55.69 with SMTP id t5mr19803524qag.82.1389452701570; Sat, 11 Jan 2014 07:05:01 -0800 (PST) Sender: jakub.php@gmail.com Received: by 10.224.68.68 with HTTP; Sat, 11 Jan 2014 07:05:01 -0800 (PST) In-Reply-To: <10f19e40b03ee19837010a988eb05706.squirrel@webmail.klapt.com> References: <10f19e40b03ee19837010a988eb05706.squirrel@webmail.klapt.com> Date: Sat, 11 Jan 2014 15:05:01 +0000 X-Google-Sender-Auth: w32QGOi8l_IhTyy-hOc2bJL0Sj0 Message-ID: To: Anatol Belski Cc: Hannes Magnusson , Nikita Popov , PHP Developers Mailing List Content-Type: multipart/alternative; boundary=047d7bdc88f2b59a9d04efb32acf Subject: Re: [PHP-DEV] [RFC] 64 bit platform improvements for string length and integer From: bukka@php.net (Jakub Zelenka) --047d7bdc88f2b59a9d04efb32acf Content-Type: text/plain; charset=ISO-8859-1 On Sat, Jan 11, 2014 at 2:48 PM, Anatol Belski wrote: > the range checks is what 'L' vs 'I' would stand for, the 'L' would be > available as alias for 'I', so one don't has to change zpp. A good thing > were to add type checks, > > Oh I see. The only small objection is that these lines could lead to the unexpected result from the user point of view: if (d > ZEND_INT_MAX) { *p = ZEND_INT_MAX; break; } else if (d < ZEND_INT_MIN) { *p = ZEND_INT_MIN; break; } I think that would make sense to add warning here Also similar checks for "s" and "p" length part (size_t -> int) would be great too! ;) Thanks Regards Jakub --047d7bdc88f2b59a9d04efb32acf--