Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:71000
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.53 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <52C7E318.5070808@fedoraproject.org>
References: <52C7E318.5070808@fedoraproject.org>
Date: Sat, 4 Jan 2014 12:24:51 +0100
Message-ID: <CAF+90c-8RUm5L=cNtEM1G7CLrCt5hAfeqhiXn_yVfPDS4THdNQ@mail.gmail.com>
To: Remi Collet <remi@fedoraproject.org>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e01494a166b287c04ef234689
Subject: Re: [PHP-DEV] Please feedback for Zend bug #66331 ZEND_SEND_PREFER_REF
 issue trying to overlad
From: nikita.ppv@gmail.com (Nikita Popov)

--089e01494a166b287c04ef234689
Content-Type: text/plain; charset=ISO-8859-1

On Sat, Jan 4, 2014 at 11:31 AM, Remi Collet <remi@fedoraproject.org> wrote:

> See https://bugs.php.net/bug.php?id=66331
> With PHPUnit real use cse (trying to mock memcached class)
>
> We have more options in Extension land that in user land.
>
> Of course if will be great to be able to correctly handle those arginfo
> mapping in userland, but we have, for now, no way to say "PREFER_REF" in
> PHP land.
>
> So my proposal is to make proto check a little less stric and consider
> ZEND_SEND_PREFER_REF as ZEND_SEND_REF, so this will allow to override a
> internal class method (using "prefer") in a php class.
>
>
> Any better idea ?
> Or could I apply this fix ?
>

Changing a prefer-ref argument into a by-ref argument via inheritance
violates LSP, so the code is right to refuse it. What I'd do instead is to
automatically convert userland by-ref arguments extending prefer-ref
arguments to also be prefer-ref. The resulting behavior might be a tad
unexpected, but I think that's better than allowing LSP violations here.

Nikita

--089e01494a166b287c04ef234689--