Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:70978
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.41 as permitted sender)
Message-ID: <52C61F08.6020105@gmail.com>
Date: Fri, 03 Jan 2014 02:23:04 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0
MIME-Version: 1.0
To: internals@lists.php.net
References: <CAGa2bXa0tn2OODr4kVC_FYtkpXsR6jGwc4172dq3WSRCdpkAzw@mail.gmail.com> <CAGa2bXZWDO7indUjK2==L1_dcXOSh20bSdXmYTN_r4AfnzexZQ@mail.gmail.com>
In-Reply-To: <CAGa2bXZWDO7indUjK2==L1_dcXOSh20bSdXmYTN_r4AfnzexZQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Re: [RFC] Introduce session.lock, session.lazy_write
 and session.lazy_destory
From: rowan.collins@gmail.com (Rowan Collins)

On 02/01/2014 20:46, Yasuo Ohgaki wrote:
> I've added session_discard() to RFC that discards changes made to
> session data and close session.
>
> Since there is session_commit(),
>
> http://www.php.net/manual/en/function.session-commit.php
>
> session_abort() may be better name for it.
> Any comment?

Since session_commit() is an alias for session_write_close(), the new 
function should probably also have "close" in its name (although oddly 
we "start" a session, rather than "open" it).

Both "discard" and "abort" also sound a bit like destroying the session 
itself to me, rather than just ignoring the current changes to it.

Perhaps something like session_revert_close() - "revert" being a closely 
analagous action in version control systems.

Regards,

-- 
Rowan Collins
[IMSoP]