Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:70919
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXZAGf7-ijr3CZaJXKCUweSe9HOcgauQoWLCOkpTusyOOA@mail.gmail.com>
References: <CAGa2bXarJDxdS0NPhFaC+20WK29bDknvcJnyWVcysXWK4o8A9A@mail.gmail.com>
	<CAGa2bXa00M4qjMM7X6bcTvcs+5-DSg2k2jpn1xH6CaJ6H++d4w@mail.gmail.com>
	<CAHMUw2Gb7GOBx=dUW4i7Mspp5dkw-EMBwUBK9TOFV9zmd2BdUg@mail.gmail.com>
	<CAGa2bXY=62y2Z_XUFuOn9gVYnmcW_qcEAO3xrTUaS2FayHm1rw@mail.gmail.com>
	<CAGa2bXayj44fmR==_2GXos-tK0ps0xNUgEQVqL=swGp1ZJkzEQ@mail.gmail.com>
	<CAGa2bXZAGf7-ijr3CZaJXKCUweSe9HOcgauQoWLCOkpTusyOOA@mail.gmail.com>
Date: Mon, 30 Dec 2013 14:45:01 +0100
Message-ID: <CAF+90c8TZeGzrLSqkYF+ADK3qYS3gOZVkTbdwOZohexzKNCFag@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Tjerk Meesters <tjerk.meesters@gmail.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bd767207ea2be04eec0a643
Subject: Re: [PHP-DEV] Re: GMP and empty()
From: nikita.ppv@gmail.com (Nikita Popov)

--047d7bd767207ea2be04eec0a643
Content-Type: text/plain; charset=ISO-8859-1

On Mon, Dec 30, 2013 at 11:23 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> Hi all,
>
> On Mon, Dec 30, 2013 at 7:02 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
>
> > Apparently, we need type check and/or float support in GMP.
> >
>
> We need error instead of type check.
> Possible patch is
>
> [yohgaki@dev php-src]$ git diff ext/gmp/
> diff --git a/ext/gmp/gmp.c b/ext/gmp/gmp.c
> index 8835f05..a64e486 100644
> --- a/ext/gmp/gmp.c
> +++ b/ext/gmp/gmp.c
> @@ -1036,6 +1036,7 @@ ZEND_FUNCTION(gmp_init)
>
>         INIT_GMP_RETVAL(gmpnumber);
>         if (convert_to_gmp(gmpnumber, number_arg, base TSRMLS_CC) ==
> FAILURE) {
> +               php_error_docref(NULL TSRMLS_CC, E_WARNING, "Bad number
> supplied");
>                 zval_dtor(return_value);
>                 RETURN_FALSE;
>         }
>
> Any comments?
>

I added an error check for the 5.6 branch (
http://git.php.net/?p=php-src.git;a=commitdiff;h=5408f1e5a68fead0057c95df57cfb1ff0cc3fe81).
Don't know why this particular branch was was not checked previously.

Nikita

--047d7bd767207ea2be04eec0a643--