Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:70917
Return-Path: <yohgaki@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 12135 invoked from network); 30 Dec 2013 10:23:49 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 30 Dec 2013 10:23:49 -0000
Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.45 as permitted sender)
X-PHP-List-Original-Sender: yohgaki@gmail.com
X-Host-Fingerprint: 209.85.215.45 mail-la0-f45.google.com  
Received: from [209.85.215.45] ([209.85.215.45:51936] helo=mail-la0-f45.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id DF/F0-06988-3B941C25 for <internals@lists.php.net>; Mon, 30 Dec 2013 05:23:48 -0500
Received: by mail-la0-f45.google.com with SMTP id eh20so5399427lab.4
        for <internals@lists.php.net>; Mon, 30 Dec 2013 02:23:44 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:sender:in-reply-to:references:from:date:message-id
         :subject:to:cc:content-type;
        bh=VMLxVn+JJihanGDFDIxWYXABpfOxWQlRX2XLLbfx5Is=;
        b=HUYE6tJj5I7zb/7DpeUPQGVB98S3UkD48TBy/ptywOCxjZ0Vi/fQCwNTPuZGu/PQWW
         AybVscm/uEl8aInW9sJq20dyKpDpvcVaJtBLA/1FFoMKczsJTkvRbUMu39DGqzP8lXXj
         BRpo7HsSbWuZojOLC4s8R8GM1TZS1aMiF4btmuzre2q5QdMsndM0hL4T68x3esNCuq3k
         2J6zW2FyKWlU2kzQfD8RR9VuzzYTGbmpmTDba5iyXsEQgPMB/iLMqMeIZbqxMedmmGUp
         DeP9Sn/RsLfi3U4ECE97nx/zn3gpMkKIUiynP2A2cihY3IxGMt5DTGadznD6CbgHy3gV
         yBTA==
X-Received: by 10.153.7.106 with SMTP id db10mr27292111lad.9.1388399024649;
 Mon, 30 Dec 2013 02:23:44 -0800 (PST)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
Received: by 10.112.6.68 with HTTP; Mon, 30 Dec 2013 02:23:04 -0800 (PST)
In-Reply-To: <CAGa2bXayj44fmR==_2GXos-tK0ps0xNUgEQVqL=swGp1ZJkzEQ@mail.gmail.com>
References: <CAGa2bXarJDxdS0NPhFaC+20WK29bDknvcJnyWVcysXWK4o8A9A@mail.gmail.com>
 <CAGa2bXa00M4qjMM7X6bcTvcs+5-DSg2k2jpn1xH6CaJ6H++d4w@mail.gmail.com>
 <CAHMUw2Gb7GOBx=dUW4i7Mspp5dkw-EMBwUBK9TOFV9zmd2BdUg@mail.gmail.com>
 <CAGa2bXY=62y2Z_XUFuOn9gVYnmcW_qcEAO3xrTUaS2FayHm1rw@mail.gmail.com> <CAGa2bXayj44fmR==_2GXos-tK0ps0xNUgEQVqL=swGp1ZJkzEQ@mail.gmail.com>
Date: Mon, 30 Dec 2013 19:23:04 +0900
X-Google-Sender-Auth: x8rMz25zzaTltHXxNux0t1-HMAE
Message-ID: <CAGa2bXZAGf7-ijr3CZaJXKCUweSe9HOcgauQoWLCOkpTusyOOA@mail.gmail.com>
To: Tjerk Meesters <tjerk.meesters@gmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1134ba56abbba204eebdd62f
Subject: Re: [PHP-DEV] Re: GMP and empty()
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a1134ba56abbba204eebdd62f
Content-Type: text/plain; charset=UTF-8

Hi all,

On Mon, Dec 30, 2013 at 7:02 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> Apparently, we need type check and/or float support in GMP.
>

We need error instead of type check.
Possible patch is

[yohgaki@dev php-src]$ git diff ext/gmp/
diff --git a/ext/gmp/gmp.c b/ext/gmp/gmp.c
index 8835f05..a64e486 100644
--- a/ext/gmp/gmp.c
+++ b/ext/gmp/gmp.c
@@ -1036,6 +1036,7 @@ ZEND_FUNCTION(gmp_init)

        INIT_GMP_RETVAL(gmpnumber);
        if (convert_to_gmp(gmpnumber, number_arg, base TSRMLS_CC) ==
FAILURE) {
+               php_error_docref(NULL TSRMLS_CC, E_WARNING, "Bad number
supplied");
                zval_dtor(return_value);
                RETURN_FALSE;
        }

Any comments?

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a1134ba56abbba204eebdd62f--