Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:70916
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.44 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CAGa2bXY=62y2Z_XUFuOn9gVYnmcW_qcEAO3xrTUaS2FayHm1rw@mail.gmail.com>
References: <CAGa2bXarJDxdS0NPhFaC+20WK29bDknvcJnyWVcysXWK4o8A9A@mail.gmail.com>
 <CAGa2bXa00M4qjMM7X6bcTvcs+5-DSg2k2jpn1xH6CaJ6H++d4w@mail.gmail.com>
 <CAHMUw2Gb7GOBx=dUW4i7Mspp5dkw-EMBwUBK9TOFV9zmd2BdUg@mail.gmail.com> <CAGa2bXY=62y2Z_XUFuOn9gVYnmcW_qcEAO3xrTUaS2FayHm1rw@mail.gmail.com>
Date: Mon, 30 Dec 2013 19:02:36 +0900
Message-ID: <CAGa2bXayj44fmR==_2GXos-tK0ps0xNUgEQVqL=swGp1ZJkzEQ@mail.gmail.com>
To: Tjerk Meesters <tjerk.meesters@gmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c344e281a07904eebd8d68
Subject: Re: [PHP-DEV] Re: GMP and empty()
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a11c344e281a07904eebd8d68
Content-Type: text/plain; charset=UTF-8

On Mon, Dec 30, 2013 at 6:47 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> And I was expecting
>
> [yohgaki@dev php-src]$ ./php-bin -d error_reporting=-1 -r
> '$f=2.2;$v=gmp_init($f); var_dump($v);'
>
> Warning: gmp_init(): Unable to convert variable to GMP - wrong type in
> Command line code on line 1
> bool(false)
>
> this kind of behavior for literal, too. ;)
>
> Why is PHP not raising error for float literal?
>

ZEND_FUNCTION(gmp_init)
{
    zval *number_arg;
    mpz_ptr gmpnumber;
    long base = 0;

    if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "z|l",
&number_arg, &base) == FAILURE) {
        return;
    }

    if (base && (base < 2 || base > MAX_BASE)) {
        php_error_docref(NULL TSRMLS_CC, E_WARNING, "Bad base for
conversion: %ld (should be between 2 and %d)", base, MAX_BASE);
        RETURN_FALSE;
    }

    INIT_GMP_RETVAL(gmpnumber);
    if (convert_to_gmp(gmpnumber, number_arg, base TSRMLS_CC) == FAILURE) {
        zval_dtor(return_value);
        RETURN_FALSE;
    }
}

Apparently, we need type check and/or float support in GMP.

Are there any technical reasons not to support GMP float?

https://gmplib.org/manual/Initializing-Floats.html#Initializing-Floats


--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a11c344e281a07904eebd8d68--