Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:70900 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 10971 invoked from network); 29 Dec 2013 03:11:54 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 29 Dec 2013 03:11:54 -0000 Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.179 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.217.179 mail-lb0-f179.google.com Received: from [209.85.217.179] ([209.85.217.179:50725] helo=mail-lb0-f179.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 38/61-31802-8F29FB25 for ; Sat, 28 Dec 2013 22:11:53 -0500 Received: by mail-lb0-f179.google.com with SMTP id w7so4999094lbi.10 for ; Sat, 28 Dec 2013 19:11:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:message-id:subject:to:content-type; bh=xQxYQM8TbHQvHLZI3WMA3b7aalr9jgFGviBwJgHyZRE=; b=UdMUUU58EA13z40y+ep8v4QvFMITl2Z6L8YKNzawJqe9SMPQ/BjysVuMf9xIGzuV7/ ziVdvHtyeekJqCLNE3l8lhm3jpcyd1V9tL6TApoh381T2ZmwKs8SIjBkh2aUcopXsZZj +qlTnB6ClEsTAYY/rs4FU6SifycBGprzZQrUxqnHVh4rUNYWu93+T9kMeyRl1GSqLA44 EhiRwnZf7FE8lkxkXYXJy2dSoG4aCQ/d9640u0qbdS059zj2/n1pr/7TJ37M3LZWZngI feW3Ga0NJr8rCVLExPdN1jSMi89r6Hzkfsvc7DCZ6xV54+uu3cvS4JPm12vfrbvAoK3p 0qIQ== X-Received: by 10.152.3.70 with SMTP id a6mr504908laa.63.1388286709342; Sat, 28 Dec 2013 19:11:49 -0800 (PST) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.112.6.68 with HTTP; Sat, 28 Dec 2013 19:11:09 -0800 (PST) Date: Sun, 29 Dec 2013 12:11:09 +0900 X-Google-Sender-Auth: acO0ZmGzCgNJKvt4NLturyJPPDw Message-ID: To: "internals@lists.php.net" Content-Type: multipart/alternative; boundary=089e014940a828285704eea3b055 Subject: 'ZIP_FL_OVERWRITE' undeclared From: yohgaki@ohgaki.net (Yasuo Ohgaki) --089e014940a828285704eea3b055 Content-Type: text/plain; charset=UTF-8 Hi all, It seems conditional compilation is required for zip extension. My system does not have zip_file_add, ZIP_FL_OVERWRITE in /usr/include/zip.h libzip 0.11.2 has these, but zip_file_add() addition is not in NEWS file somehow. OS: Fedora19 x86_64 [yohgaki@dev php-src]$ rpm -q libzip-devel libzip-devel-0.10.1-6.fc19.x86_64 cc -I/usr/lib64/libzip/include -Iext/zip/ -I/home/yohgaki/git/oss/ php.net/php-src/ext/zip/ -DPHP_ATOM_INC -I/home/yohgaki/git/oss/ php.net/php-src/include -I/home/yohgaki/git/oss/php.net/php-src/main-I/home/yohgaki/git/oss/ php.net/php-src -I/home/yohgaki/git/oss/php.net/php-src/ext/date/lib-I/home/yohgaki/git/oss/ php.net/php-src/ext/ereg/regex -I/usr/include/libxml2 -I/usr/include/enchant -I/usr/X11 -I/usr/include/freetype2 -I/usr/include/imap -I/usr/interbase/include -I/home/yohgaki/git/oss/ php.net/php-src/ext/mbstring/oniguruma -I/home/yohgaki/git/oss/ php.net/php-src/ext/mbstring/libmbfl -I/home/yohgaki/git/oss/ php.net/php-src/ext/mbstring/libmbfl/mbfl -I/usr/local/pgsql/include -I/home/yohgaki/git/oss/php.net/php-src/ext/sqlite3/libsqlite-I/usr/include/pspell -I/usr/local/include -I/home/yohgaki/git/oss/ php.net/php-src/TSRM -I/home/yohgaki/git/oss/php.net/php-src/Zend-I/usr/include -g -fvisibility=hidden -O0 -Wall -c /home/yohgaki/git/oss/ php.net/php-src/ext/zip/php_zip.c -fPIC -DPIC -o ext/zip/.libs/php_zip.o /home/yohgaki/git/oss/php.net/php-src/ext/zip/php_zip.c: In function 'php_zip_add_file': /home/yohgaki/git/oss/php.net/php-src/ext/zip/php_zip.c:339:2: warning: implicit declaration of function 'zip_file_add' [-Wimplicit-function-declaration] if (zip_file_add(za, entry_name, zs, ZIP_FL_OVERWRITE) < 0) { ^ /home/yohgaki/git/oss/php.net/php-src/ext/zip/php_zip.c:339:39: error: 'ZIP_FL_OVERWRITE' undeclared (first use in this function) if (zip_file_add(za, entry_name, zs, ZIP_FL_OVERWRITE) < 0) { -- Yasuo Ohgaki yohgaki@ohgaki.net --089e014940a828285704eea3b055--