Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:70895 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 52732 invoked from network); 28 Dec 2013 04:37:37 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 28 Dec 2013 04:37:37 -0000 Authentication-Results: pb1.pair.com smtp.mail=laruence@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=laruence@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.49 as permitted sender) X-PHP-List-Original-Sender: laruence@gmail.com X-Host-Fingerprint: 209.85.215.49 mail-la0-f49.google.com Received: from [209.85.215.49] ([209.85.215.49:64794] helo=mail-la0-f49.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 15/37-11616-F855EB25 for ; Fri, 27 Dec 2013 23:37:36 -0500 Received: by mail-la0-f49.google.com with SMTP id er20so4494421lab.8 for ; Fri, 27 Dec 2013 20:37:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=fjQRa4K11jFCcJ5NxuAYUMiMH+QIjM8SoWufn7w/kVY=; b=PqJIlWU2doF+hVU6Zd2RqPW7l47WPSXxWVC1vfoud2KwGGcDPjE4tYNxJzm2bfl4np YW9rdyMWWXk8rLZ7WHj/Ozu3aJ4Nniiotge6fiobS3VHsta5j89DfGdZjVbQErbGEYJT lEmcuIEiVih/h46nEAZBN7KTRAeALNIF/hFUN04IGg67KN75f8CLDnDKAdZRyHWm/zA/ JJwxamCQ4e+Vxqn5YEzWB2WoJgKp/1flwEW7G9GeZZ7r1saL3brEBJ722J9vuIwEq/px raKlOTSR19/0IHhi2T6BFmM5VAIvOansemy4RpIJ4FrY3MVzrmim2ncLlPt6RNmmb7hm 2R+A== X-Received: by 10.112.135.165 with SMTP id pt5mr6929352lbb.33.1388205452719; Fri, 27 Dec 2013 20:37:32 -0800 (PST) MIME-Version: 1.0 Received: by 10.114.190.230 with HTTP; Fri, 27 Dec 2013 20:37:12 -0800 (PST) In-Reply-To: References: <52BD10E3.9070005@sugarcrm.com> <52BE02E0.5010904@sugarcrm.com> <52BE0377.7000500@lerdorf.com> Date: Sat, 28 Dec 2013 12:37:12 +0800 Message-ID: To: Pierre Joye Cc: Rasmus Lerdorf , PHP internals , Yasuo Ohgaki , Stas Malyshev Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] Re: imagecrop fix From: laruence@gmail.com (Xinchen Hui) On Sat, Dec 28, 2013 at 12:09 PM, Pierre Joye wrote: > On Sat, Dec 28, 2013 at 5:04 AM, Gmail wrote: >> >> >> Sent from my iPhone >> >>> On Dec 28, 2013, at 11:10 AM, Pierre Joye wrote: >>> >>>> On Dec 28, 2013 5:47 AM, "Rasmus Lerdorf" wrote: >>>> >>>> >>>> And much of that code isn't in 5.3. ImageCrop() is new in 5.5, for >>> example. >>> >>> Yes, but the commit changed other functions (news has to be updated >>> accordingly). I won't be able to test or valid the patch before the 6th= , so >>> if anyone likes or has time to do it, go ahead. >> No behavior changed, previously , these function will modify the paramet= er if the item in it is not expected type, it should be fixed. > > Right but the news file and commit message was not correct. Both > should reflect what is being fixed (useful info for distros too) :) > > Btw, have you read the reporter's comment as well as mines? It looks > like this fix is incomplete. Ah, right, the desc is long, I have troubles with reading long text.... :< I will have a try to fix rests.. thanks > > Cheers, > -- > Pierre > > @pierrejoye | http://www.libgd.org --=20 =E6=83=A0=E6=96=B0=E5=AE=B8 laruence Senior PHP Engineer http://www.laruence.com