Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:70894
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.171 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <BFFFCD28-A9C9-48B0-9B6E-92D050201DD7@gmail.com>
References: <52BD10E3.9070005@sugarcrm.com>
	<CAGa2bXbtF=kSe3hJtgDkp3kmtmeNi-A0qxZp-fTBre-ochmf1A@mail.gmail.com>
	<52BE02E0.5010904@sugarcrm.com>
	<52BE0377.7000500@lerdorf.com>
	<CAEZPtU77cu3_eZp2xnGQ9gp0OeuPuUjgh=zQyLpR0y_RpdZOFw@mail.gmail.com>
	<BFFFCD28-A9C9-48B0-9B6E-92D050201DD7@gmail.com>
Date: Sat, 28 Dec 2013 05:09:32 +0100
Message-ID: <CAEZPtU4CoFqOz8tg5xgdo8kk_LVGMXC0dzf_wwO_u77nWqnm-w@mail.gmail.com>
To: Gmail <laruence@gmail.com>
Cc: Rasmus Lerdorf <rasmus@lerdorf.com>, PHP internals <internals@lists.php.net>, 
	Yasuo Ohgaki <yohgaki@ohgaki.net>, Stas Malyshev <smalyshev@sugarcrm.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Re: imagecrop fix
From: pierre.php@gmail.com (Pierre Joye)

On Sat, Dec 28, 2013 at 5:04 AM, Gmail <laruence@gmail.com> wrote:
>
>
> Sent from my iPhone
>
>> On Dec 28, 2013, at 11:10 AM, Pierre Joye <pierre.php@gmail.com> wrote:
>>
>>> On Dec 28, 2013 5:47 AM, "Rasmus Lerdorf" <rasmus@lerdorf.com> wrote:
>>>
>>>
>>> And much of that code isn't in 5.3. ImageCrop() is new in 5.5, for
>> example.
>>
>> Yes, but the commit changed other functions (news has to be updated
>> accordingly). I won't be able to test or valid the patch before the 6th, so
>> if anyone likes or has time to do it, go ahead.
> No behavior changed, previously , these function will modify the parameter if the item in it is not expected type, it should be fixed.

Right but the news file and commit message was not correct. Both
should reflect what is being fixed (useful info for distros too) :)

Btw, have you read the reporter's comment as well as mines? It looks
like this fix is incomplete.

Cheers,
-- 
Pierre

@pierrejoye | http://www.libgd.org