Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:70888
Return-Path: <rasmus@lerdorf.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 32897 invoked from network); 27 Dec 2013 22:47:24 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 27 Dec 2013 22:47:24 -0000
Authentication-Results: pb1.pair.com smtp.mail=rasmus@lerdorf.com; spf=permerror; sender-id=unknown
Authentication-Results: pb1.pair.com header.from=rasmus@lerdorf.com; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain lerdorf.com from 209.85.216.48 cause and error)
X-PHP-List-Original-Sender: rasmus@lerdorf.com
X-Host-Fingerprint: 209.85.216.48 mail-qa0-f48.google.com  
Received: from [209.85.216.48] ([209.85.216.48:58609] helo=mail-qa0-f48.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 5F/C3-11616-B730EB25 for <internals@lists.php.net>; Fri, 27 Dec 2013 17:47:23 -0500
Received: by mail-qa0-f48.google.com with SMTP id w5so9069393qac.0
        for <internals@lists.php.net>; Fri, 27 Dec 2013 14:47:20 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
         :cc:subject:references:in-reply-to:content-type
         :content-transfer-encoding;
        bh=+EQe+lHXvKIuglu5UtIdrZDx79xMQUshZT28d9t/M1M=;
        b=MAkB6zsy4Xv8w2tblVStQ73jqvZY8PzGegpw0MG0yQDwenUwb+hX0r/HRoAqfn+o92
         3GierGPxvrw4b0+8pycyOfBolRBkoT6OEJPl7iQugzn5I/WXPcvp/lyKp65Ly7L77cMO
         7ME+c4MKQDIpYXXJTWhkDoghH+tMGBu6oTQJgo1ekYLmCArb+DzZUnRlLrENNrNutxiW
         8xzQjkp48+ienVVEMngrQwQUmg2jcS7C/C4JqH25MDCeGsZzjA/rp4Yq7KeRLSuyVTsQ
         LLHFXzv+KZ5ArZyEwlf/eS2e3v5kxVEcp/cIN3oqu2yKTGJT/P9xQnB+gF9nRjEglioQ
         D6XQ==
X-Gm-Message-State: ALoCoQnRZ1/dRLjJuh2N3XOEtIT4jtfMOCTp0iUe4dRtZVIw7MClxHVVe6JhbGSqXB32BJBHfld/
X-Received: by 10.224.2.194 with SMTP id 2mr32987730qak.44.1388184440764;
        Fri, 27 Dec 2013 14:47:20 -0800 (PST)
Received: from [192.168.2.140] (CPE00131063dcac-CM0011aec551ea.cpe.net.cable.rogers.com. [99.248.138.9])
        by mx.google.com with ESMTPSA id nq5sm56377883qeb.8.2013.12.27.14.47.19
        for <multiple recipients>
        (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
        Fri, 27 Dec 2013 14:47:20 -0800 (PST)
Message-ID: <52BE0377.7000500@lerdorf.com>
Date: Fri, 27 Dec 2013 17:47:19 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0
MIME-Version: 1.0
To: Stas Malyshev <smalyshev@sugarcrm.com>, 
 Yasuo Ohgaki <yohgaki@ohgaki.net>
CC: PHP Internals <internals@lists.php.net>
References: <52BD10E3.9070005@sugarcrm.com> <CAGa2bXbtF=kSe3hJtgDkp3kmtmeNi-A0qxZp-fTBre-ochmf1A@mail.gmail.com> <52BE02E0.5010904@sugarcrm.com>
In-Reply-To: <52BE02E0.5010904@sugarcrm.com>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Re: imagecrop fix
From: rasmus@lerdorf.com (Rasmus Lerdorf)

On 12/27/2013 05:44 PM, Stas Malyshev wrote:
> Hi!
> 
>> Isn't this good for 5.3?
>>
>> http://git.php.net/?p=php-src.git;a=commitdiff;h=2938329ce19cb8c4197dec146c3ec887c6f61d01
> 
> It might be a good idea to merge, but as far as I understand, the bug is
> not completely fixed yet. So I'd prefer to wait until the fix is
> complete and merge all of it then.
> 

And much of that code isn't in 5.3. ImageCrop() is new in 5.5, for example.

-Rasmus