Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:70761 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 14670 invoked from network); 19 Dec 2013 21:42:24 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 19 Dec 2013 21:42:24 -0000 Authentication-Results: pb1.pair.com smtp.mail=martin@divbyzero.net; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=martin@divbyzero.net; sender-id=unknown Received-SPF: error (pb1.pair.com: domain divbyzero.net from 87.230.111.147 cause and error) X-PHP-List-Original-Sender: martin@divbyzero.net X-Host-Fingerprint: 87.230.111.147 mx.bauer-kirch.de Linux 2.6 Received: from [87.230.111.147] ([87.230.111.147:50071] helo=mx.bauer-kirch.de) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 4E/AB-42949-04863B25 for ; Thu, 19 Dec 2013 16:42:24 -0500 Received: by mx.bauer-kirch.de with ESMTP id 1VtlML-0003Qr-BQ for ; Thu, 19 Dec 2013 22:42:21 +0100 Received: from martin by scalar.home with local (Exim 4.74) (envelope-from ) id 1VtlML-0003BC-Fd for internals@lists.php.net; Thu, 19 Dec 2013 22:42:21 +0100 Date: Thu, 19 Dec 2013 22:42:21 +0100 To: internals@lists.php.net Message-ID: <20131219214221.GA12078@scalar.divbyzero.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Return value of ext/intl constructors upon errors From: martin@divbyzero.net (Martin Jansen) While looking into #66323 I noticed that the constructor methods of the classes in ext/intl like IntlDateFormatter and NumberFormatter return NULL when encountering errors like illegal timezones instead of FALSE as suggested by the manual. Other OO-style parts of the core like DateTime also seem to be using mostly FALSE in such situations. Fixing intl will result in a slight BC wreakage, which makes me wonder if that's worth it. What's the general opinion? - Martin