Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:70681
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.178 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXZH1rgh7XzQd-Tswdod4gRAxgj9-fc-hV=49JrEK8fpdw@mail.gmail.com>
References: <CAGa2bXbjh7EyzRf_uahHp0rfs21efqReHZKQchvB8CGjNc_Qaw@mail.gmail.com>
	<CAGa2bXbGdC-6hcdEdQmzUn8xVKLa5Ro9NyGyFkhuMueoXuoing@mail.gmail.com>
	<CADajX4DxvtZ3+fX5f6ndHOGmGs+ZAgSPFkRHVOqUwO9y5y1ZZg@mail.gmail.com>
	<CAGa2bXZH1rgh7XzQd-Tswdod4gRAxgj9-fc-hV=49JrEK8fpdw@mail.gmail.com>
Date: Mon, 16 Dec 2013 17:13:07 -0500
Message-ID: <CAL+t6cH+hKKgWWwF2z8bqX9Sbh1090GPewEMLKc_1ateH3+adA@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Adam Harvey <aharvey@php.net>, "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bd915dad0a63304edae1d25
Subject: Re: [PHP-DEV] Re: Making addslashes() multibyte aware
From: theanomaly.is@gmail.com (Sherif Ramadan)

--047d7bd915dad0a63304edae1d25
Content-Type: text/plain; charset=ISO-8859-1

On Mon, Dec 16, 2013 at 4:41 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> On Tue, Dec 17, 2013 at 5:54 AM, Adam Harvey <aharvey@php.net> wrote:
>
> > On 16 December 2013 12:44, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
>
>  > I'll fix php_addslashes(). Therefore, any functions that use it
> > internally
> > > are affected. e.g. var_export(), etc. Users are not affected as long as
> > > they are using correct locale.
> > >
> > > Should I fix this from 5.3?
> >
> > This feels like it has the potential to be a really nasty implicit BC
> > break. I don't think we'd want to change default behaviour on any
> > stable branch, honestly.
>
>
> I cannot object this argument.
> There may be unexpected side effects.
> However, users will not be affected as long as they are using correct
> locale if locale system is not broken...
>
>
But honestly, how many users will set their locale to SJIS/BIG5 when
dealing with multibyte charsets like those? I typically never touch locales
when dealing with code that handles multibyte charsets (and that's becoming
more and more often these days), because it rarely makes sense. It makes a
lot more sense to me to deal with those issues on the intl/mb_* level and
as for serialization I hardly think that serialize() with addslashes is a
problem PHP needs to fix. More likely the correct and better fix is for
those developers to be more charset-conscious while making decisions about
how to handle serialized data after transport.

--047d7bd915dad0a63304edae1d25--