Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:70637
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.47 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <52AC5E19.8060203@lsces.co.uk>
References: <52ABA642.9090206@php.net> <52ABA947.4030908@ajf.me> <52AC5E19.8060203@lsces.co.uk>
Date: Sat, 14 Dec 2013 14:51:05 +0100
Message-ID: <CADyq6s+r1kSPMLLhwY=t2Lx3MVMXAiQXe9=zNA=bWwxY4D5DfA@mail.gmail.com>
To: Lester Caine <lester@lsces.co.uk>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bdcad4cea90ca04ed7edf78
Subject: Re: [PHP-DEV] Proposal for RFC: get_class_constants()
From: ocramius@gmail.com (Marco Pivetta)

--047d7bdcad4cea90ca04ed7edf78
Content-Type: text/plain; charset=UTF-8

On 14 December 2013 14:33, Lester Caine <lester@lsces.co.uk> wrote:

If it is the only reason you are having to activate reflections?
Reflections would seem to have a place, but is it really necessary to add
yet another layer when most of the time it's function is provided better by
IDE tools anyway? This is a simple example of a current hole in the core
PHP tools which would help a section of developers who don't need the
overheads of additional layers.

@Lester additional layer is still better than *yet another shortcut*.

Since we already have the feature, introducing another flavor for it seems
a bit of an overkill, especially if it also has to be maintained.

Any userland implementation can handle this by also being fast enuff:

function get_class_constants($className)
{
    static $cached = [];

    if (isset($cached[$className])) {
        return $cached[$className];
    }

    return $cached[$class] = (new \ReflectionClass($class))->getConstants();
}


Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

--047d7bdcad4cea90ca04ed7edf78--