Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:70633
Return-Path: <yohgaki@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 81982 invoked from network); 14 Dec 2013 04:23:22 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 14 Dec 2013 04:23:22 -0000
Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.178 as permitted sender)
X-PHP-List-Original-Sender: yohgaki@gmail.com
X-Host-Fingerprint: 209.85.216.178 mail-qc0-f178.google.com  
Received: from [209.85.216.178] ([209.85.216.178:36003] helo=mail-qc0-f178.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 42/50-11187-83DDBA25 for <internals@lists.php.net>; Fri, 13 Dec 2013 23:23:21 -0500
Received: by mail-qc0-f178.google.com with SMTP id i17so2182896qcy.37
        for <internals@lists.php.net>; Fri, 13 Dec 2013 20:23:18 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:sender:from:date:message-id:subject:to:content-type;
        bh=wVNJG0e9NluHc3D2egfRb2maPrasW7awKlfZTXz/kAw=;
        b=uJzdV88lc3Fh/xHDgzNT9yRYNBzTcmkLGzrLNnvh7YAjnSK+nvMlq3IyAu3bmrXfRi
         XZ64KMclhtuUlVYzS6moRfovXwMf1FlNz5l1Bd9V+HNNa9J5HWq4niLyk2i8ZIeRQ5XV
         i3x2poYBkBMEveMsGGlMEOU4YsH3BdA2bo3ZFToBZsyXc8sJTDnNfb3GZzkiY5OhE/tY
         J3vMQKW8+EMk0WHMShjYk5tbtFfTEHl7OrPCRFdyVcLJL1xWAXGrPQFC2TwE80D1nbwj
         PCFS1CIpmcq8OlUWzGOX7X2qwaCvwPpqSDAyJm3F/2i486T3vQBxWuhjOXTipaKmHmR6
         eGEQ==
X-Received: by 10.224.89.73 with SMTP id d9mr11120268qam.5.1386994998315; Fri,
 13 Dec 2013 20:23:18 -0800 (PST)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
Received: by 10.224.23.129 with HTTP; Fri, 13 Dec 2013 20:22:38 -0800 (PST)
Date: Sat, 14 Dec 2013 13:22:38 +0900
X-Google-Sender-Auth: kn7_U-sqE8rq0KDjvQN8GoUHeqA
Message-ID: <CAGa2bXbjh7EyzRf_uahHp0rfs21efqReHZKQchvB8CGjNc_Qaw@mail.gmail.com>
To: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c3ce542e114404ed76f05e
Subject: Making addslashes() multibyte aware
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a11c3ce542e114404ed76f05e
Content-Type: text/plain; charset=UTF-8

Hi all,

escapeshellargs()/fgetcsv() have multibyte char support via mblen() which
depends on LC_TYPE, but addslashes() don't take into count MBCS at all.

addslashes() could behave like escapeshellargs(). Current addslashes()
is not usable with SJIS/BIG5/etc.

Depending on locale is problematic. Is it safe with multi threaded SAPI?
Using mbstring feature and introduce encoding php.ini setting might be
better.

Any comment making addslashes() locale aware? and/or current
escapeshellargs()/fgetcsv() implementation?

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a11c3ce542e114404ed76f05e--