Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:7062 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 99939 invoked by uid 1010); 13 Jan 2004 21:07:15 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 99915 invoked from network); 13 Jan 2004 21:07:15 -0000 Received: from unknown (HELO edwardbear.org) (216.179.74.133) by pb1.pair.com with SMTP; 13 Jan 2004 21:07:15 -0000 Received: by edwardbear.org via sendmail from stdin id (Debian Smail3.2.0.115) Tue, 13 Jan 2004 16:06:44 -0500 (EST) Date: Tue, 13 Jan 2004 16:06:44 -0500 To: Andi Gutmans Cc: internals@lists.php.net Message-ID: <20040113210644.GF23361@bumblebury.com> References: <20040113200330.GE23361@bumblebury.com> <5.1.0.14.2.20040113225823.04cd6ec0@127.0.0.1> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5.1.0.14.2.20040113225823.04cd6ec0@127.0.0.1> User-Agent: Mutt/1.5.4i Subject: Re: [PHP-DEV] fix for bug #26696 From: sterling@php.net (Sterling Hughes) > Are you sure this is OK? It seems strange that string offsets don't need > any unlocking. It might mean we have a problem someplace else and that > you're fixing the cause and not the source of the problem (although I > haven't had time to dig deep). > In general, consider the following code: > $a = "Foo"; > > switch ($a[0]) { > case 'b': > break; > case 'c': > break; > case 'F': > break; > } > > Are you sure this doesn't leak now? I don't have time to look at it now, > but if you are absolutely convinced the patch makes sense I'll try and step > through it with a debugger as soon as I have some free time. > No, I was wrong. I hate the memory manager, it cleans up my leaks for me - makes it impossible to rely on valgrind. ;) Anyway to turn that off? I'm playing around some more now. -Sterling