Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:70550 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 31720 invoked from network); 9 Dec 2013 14:39:29 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 9 Dec 2013 14:39:29 -0000 Authentication-Results: pb1.pair.com smtp.mail=mike.php.net@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=mike.php.net@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.83.46 as permitted sender) X-PHP-List-Original-Sender: mike.php.net@gmail.com X-Host-Fingerprint: 74.125.83.46 mail-ee0-f46.google.com Received: from [74.125.83.46] ([74.125.83.46:43994] helo=mail-ee0-f46.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 7A/70-28714-F16D5A25 for ; Mon, 09 Dec 2013 09:39:28 -0500 Received: by mail-ee0-f46.google.com with SMTP id d49so1593254eek.19 for ; Mon, 09 Dec 2013 06:39:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-type:mime-version:content-transfer-encoding; bh=rD5sY9hvRs+h+iGWpibSCXF/wUqJPvlXzBQApChMvSc=; b=aRbc6V3unQDvXGgdmIzvOgq8PZ7i7j8GgxT20KxAX6QGziiURXuolvMJ+INr6kwDza CVywFoZwuGg/PMdDWhyCo6tMcvFF+/RtGikg4uYqh9u7+JuXJL+zi2N8dsRl/wGhtC75 qVLlWtAcJBlFlk9Txf1bstcdtFYMPbYjYAH0o8KgHvCInGf1AvVPnKHm6pefrLWMB5sI N0mWqAYCxiFgjvNqVImk6ynJ2SV8yyUkg1dKiw1pPT2kVRdK30+RqiBv9oiwhvcGoqr4 4A/Olfl7LfSP0jsbBLJQ6AWqTeGpxlszxDDrl6bKe/rr2u+puSuUZM6f26W13fyin3vg DNHA== X-Received: by 10.14.108.6 with SMTP id p6mr12834206eeg.31.1386599964733; Mon, 09 Dec 2013 06:39:24 -0800 (PST) Received: from [192.168.1.120] (178-18-170-101.customer.bnet.at. [178.18.170.101]) by mx.google.com with ESMTPSA id a51sm29483334eeh.8.2013.12.09.06.39.23 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 09 Dec 2013 06:39:24 -0800 (PST) Message-ID: <1386599962.9685.6.camel@smugmug> To: Ferenc Kovacs Cc: Julien Pauli , Adam Harvey , Yasuo Ohgaki , "internals@lists.php.net" , Michael Wallner , Ryan McCue Date: Mon, 09 Dec 2013 15:39:22 +0100 In-Reply-To: References: <5293E54F.9060604@rotorised.com> <1385628146.16543.0.camel@smugmug> <1385969508.2637.3.camel@smugmug> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Re: [RFC] Slim POST data (was: PHP-5.6 and $HTTP_RAW_POST_DATA) From: mike.php.net@gmail.com (Mike) On Mon, 2013-12-09 at 15:17 +0100, Ferenc Kovacs wrote: > > > > On Sat, Dec 7, 2013 at 8:39 AM, Ferenc Kovacs > wrote: > > > > I think it would make sense, to have an RFC > for 5.6 about introducing > > the new stream, the new ini option and and > how does it keeps userland > > BC while providing a way to opt-in for the > performance gain, and that > > it introduces an E_DEPRECATED so we can > remove the ini and the raw > > post global variable in the next major > version. > > > I think we cannot add E_DEPRECATED to the > INI-setting unless we make its > default -1... which breaks BC :p > > Also, I think two RFCs would be quite much, > but I already gave up my > renitency. > > > we could emmit the error from populate_raw_post_data > in main/php_content_types.c, telling people that the > auto population of $HTTP_RAW_POST_DATA along with the > use of always_populate_raw_post_data will go away, and > they should set always_populate_raw_post_data to -1 > and populate that variable for themself if their want > to be forward compatible (and silence the E_DEPRECATED > messages). > > > > > > Hi, > > > Any update on this? > I would be ok to merge with the PR in the current form, as it > resolves the BC issue, but if we want to remove the INI > setting in the future, then adding the E_DEPRECATED would be > important step. > Ok, I'll change that and open for votes then! Thanks, Mike