Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:70548
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain zend.com from 74.125.82.182 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAEZPtU6=1rVcZJ6jukzNG9cjHzvipy4yR=FRXpPKvmn_6nnW2Q@mail.gmail.com>
References: <CAF+90c-NU7fuHBj8FFX8DrP4RFy7bPEbn_pCTn7hMUDt8_Cdxg@mail.gmail.com>
	<52A50E18.9070106@sugarcrm.com>
	<CA+9eiLtfrsS48JjMC1DaR0xxxDk_AHe8NkkxtrQh-ECDCv=O_A@mail.gmail.com>
	<CAEZPtU6=1rVcZJ6jukzNG9cjHzvipy4yR=FRXpPKvmn_6nnW2Q@mail.gmail.com>
Date: Mon, 9 Dec 2013 16:28:05 +0400
Message-ID: <CA+9eiLuTWSgPV7H9HJ7jzDdP=HYB4Y_PUQJzc9eDzfxGEDrXXQ@mail.gmail.com>
To: Pierre Joye <pierre.php@gmail.com>
Cc: PHP internals <internals@lists.php.net>, Stas Malyshev <smalyshev@sugarcrm.com>, 
	Nikita Popov <nikita.ppv@gmail.com>
Content-Type: multipart/alternative; boundary=f46d044280b4b623e904ed1920f2
Subject: Re: [PHP-DEV] func_get_args BC break
From: dmitry@zend.com (Dmitry Stogov)

--f46d044280b4b623e904ed1920f2
Content-Type: text/plain; charset=UTF-8

Hi Pierre,

It was a performance improvement that caused that BC break.
For some reason func_get_arg() made a copy of each argument.
In case some argument is a big array it made a significant useless work
creating and filling new HashTable.

Thanks. Dmitry.


On Mon, Dec 9, 2013 at 3:10 PM, Pierre Joye <pierre.php@gmail.com> wrote:

>
> On Dec 9, 2013 8:46 AM, "Dmitry Stogov" <dmitry@zend.com> wrote:
> >
> > Hi,
> >
> > I agree that the change makes BC break for some tricky code :(
> > and i don't insist to keep it in 5.5.
>
> An old enough bug may become a feature.
>
> I am not sure it should be kept for 5.6 either. As of the last "dramatic"
> performance loss (about some string funcs), what are you referencing to
> here?
>
> Cheers,
> Pierre
>

--f46d044280b4b623e904ed1920f2--