Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:70546
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain zend.com from 209.85.212.170 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAH-PCH5hsg-YFj2B4+bVU8LF7k2F=euMiNfmpfGXy0osLqpxMQ@mail.gmail.com>
References: <CAF+90c-NU7fuHBj8FFX8DrP4RFy7bPEbn_pCTn7hMUDt8_Cdxg@mail.gmail.com>
	<52A50E18.9070106@sugarcrm.com>
	<CA+9eiLtfrsS48JjMC1DaR0xxxDk_AHe8NkkxtrQh-ECDCv=O_A@mail.gmail.com>
	<CAH-PCH5hsg-YFj2B4+bVU8LF7k2F=euMiNfmpfGXy0osLqpxMQ@mail.gmail.com>
Date: Mon, 9 Dec 2013 13:27:51 +0400
Message-ID: <CA+9eiLuASjai5TxvatHu4kQ7TemVg8-RphX6quynqWjEH3aJ5A@mail.gmail.com>
To: Ferenc Kovacs <tyra3l@gmail.com>
Cc: Stas Malyshev <smalyshev@sugarcrm.com>, Nikita Popov <nikita.ppv@gmail.com>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=f46d04138c9f24cb1704ed169c01
Subject: Re: [PHP-DEV] func_get_args BC break
From: dmitry@zend.com (Dmitry Stogov)

--f46d04138c9f24cb1704ed169c01
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

I'm completely disagree.
That PHP code (in bug report) worked not by design.
Actually, it's wrong code that worked just because of luck (zval refcount
became 1).
I don't see any reason to keep such compatibility for 5.6 in cost of
performance.

Thanks. Dmitry.



On Mon, Dec 9, 2013 at 12:31 PM, Ferenc Kovacs <tyra3l@gmail.com> wrote:

>
>
>
> On Mon, Dec 9, 2013 at 7:45 AM, Dmitry Stogov <dmitry@zend.com> wrote:
>
>> Hi,
>>
>> I agree that the change makes BC break for some tricky code :(
>> and i don't insist to keep it in 5.5.
>>
>> Thanks. Dmitry.
>>
>>
>>
>>
>> On Mon, Dec 9, 2013 at 4:26 AM, Stas Malyshev <smalyshev@sugarcrm.com
>> >wrote:
>>
>> > Hi!
>> >
>> > Can we do anything to fix it? Is the problem limited only to
>> > pass-object-by-ref or also for other by-ref scenarios? In the latter
>> > case it does constitute a BC break I think and it may be a good idea t=
o
>> > move it to 5.6...
>> >
>> >
>>
>
> Hi,
>
> as we agreed that this is a BC break, I don't think that it is a good ide=
a
> even for 5.6.
> could we also create a test for this behavior, so we don't change this
> unintentionally later on?
>
>
> --
> Ferenc Kov=C3=A1cs
> @Tyr43l - http://tyrael.hu
>

--f46d04138c9f24cb1704ed169c01--