Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:70542
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain zend.com from 209.85.212.182 cause and error)
MIME-Version: 1.0
In-Reply-To: <52A50E18.9070106@sugarcrm.com>
References: <CAF+90c-NU7fuHBj8FFX8DrP4RFy7bPEbn_pCTn7hMUDt8_Cdxg@mail.gmail.com>
	<52A50E18.9070106@sugarcrm.com>
Date: Mon, 9 Dec 2013 10:45:59 +0400
Message-ID: <CA+9eiLtfrsS48JjMC1DaR0xxxDk_AHe8NkkxtrQh-ECDCv=O_A@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: Nikita Popov <nikita.ppv@gmail.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bb04a124685ed04ed145940
Subject: Re: [PHP-DEV] func_get_args BC break
From: dmitry@zend.com (Dmitry Stogov)

--047d7bb04a124685ed04ed145940
Content-Type: text/plain; charset=UTF-8

Hi,

I agree that the change makes BC break for some tricky code :(
and i don't insist to keep it in 5.5.

Thanks. Dmitry.




On Mon, Dec 9, 2013 at 4:26 AM, Stas Malyshev <smalyshev@sugarcrm.com>wrote:

> Hi!
>
> Can we do anything to fix it? Is the problem limited only to
> pass-object-by-ref or also for other by-ref scenarios? In the latter
> case it does constitute a BC break I think and it may be a good idea to
> move it to 5.6...
>
>
> -------- Original Message --------
> Subject: [PHP-DEV] func_get_args BC break
> Date: Sat, 7 Dec 2013 06:15:51 -0600
> From: Nikita Popov <nikita.ppv@gmail.com>
> To: PHP internals <internals@lists.php.net>
>
> Hi internals!
>
> The performance optimizations to func_get_args that were introduced in PHP
> 5.5.6 break BC for call_user_func_array on functions with by-ref args, see
> https://bugs.php.net/bug.php?id=66107.
>
> While using that kind of code is wrong in the first place, this seems like
> a nasty break for a bugfix release. Maybe revert this for 5.5 and only keep
> in 5.6?
>
> Nikita
>
>
>

--047d7bb04a124685ed04ed145940--