Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:70527 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 32500 invoked from network); 8 Dec 2013 05:17:26 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Dec 2013 05:17:26 -0000 Authentication-Results: pb1.pair.com header.from=laruence@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=laruence@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.44 as permitted sender) X-PHP-List-Original-Sender: laruence@gmail.com X-Host-Fingerprint: 209.85.215.44 mail-la0-f44.google.com Received: from [209.85.215.44] ([209.85.215.44:52969] helo=mail-la0-f44.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 03/54-01020-3E004A25 for ; Sun, 08 Dec 2013 00:17:24 -0500 Received: by mail-la0-f44.google.com with SMTP id ep20so883091lab.31 for ; Sat, 07 Dec 2013 21:17:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=pRew1H65ThYmTehSSfCPPBRgEzbOknxUT5GKlZ/liBA=; b=w0Zl04V61oUHBdaQzxHTJCEzGZaBC4MIH6rfC+4xFp3OiZhjXLXSic3ZhMe0cCsEMN T3uJh0V/EVdYaZZJ+l9G9QjQvtK/03+4baNo2Zg2sDeOGo2UKXVi1KuEwFyriRrUgRVC 14RYQLVhjVP3+3lYd9q+Q6XEhurKiewOSrwEQnRBXC2yWwc3AOTKYX17t3UDzwRyBNhz iBGuiLoYBcO8C85fZNRX02a55WD9BcG00NBs9dyLvFpHgCE0W9TWvnbracSr9gOopyzB ebmFn6QEFZtoAFcwrnR7/L8HrF3z0uiuencDo4Kv6S4j8jCFVvJ/gjoHyy4SydY+yOBw ilVg== X-Received: by 10.112.173.137 with SMTP id bk9mr145270lbc.48.1386479840330; Sat, 07 Dec 2013 21:17:20 -0800 (PST) MIME-Version: 1.0 Sender: laruence@gmail.com Received: by 10.114.157.199 with HTTP; Sat, 7 Dec 2013 21:17:00 -0800 (PST) In-Reply-To: References: <529D1197.5000305@nebm.ist.utl.pt> <8BCA5A38-788B-4E6A-A6AC-1A8DCBA3D8D9@zend.com> <759ccd0f06663defc84ffee473b51210@mail.gmail.com> <1386064737.2637.8.camel@smugmug> <1734470932732186750@unknownmsgid> Date: Sun, 8 Dec 2013 13:17:00 +0800 X-Google-Sender-Auth: bBbWaUZNKZ2NhCN7o2nfElM952g Message-ID: To: Pierre Joye Cc: Dmitry Stogov , Zeev Suraski , Andi Gutmans , PHP Internals , Hannes Magnusson , Gustavo Lopes , Mike , Gadi Goldbarg Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] strtr() performance degradation From: laruence@php.net (Laruence) On Fri, Dec 6, 2013 at 4:06 PM, Laruence wrote: > On Tue, Dec 3, 2013 at 9:30 PM, Pierre Joye wrote: >> hi Dmitry! >> >> >> On Tue, Dec 3, 2013 at 12:24 PM, Dmitry Stogov wrote: >>> >>> ZF2 :) >>> Screen-short explains it. >>> >>> Thanks. Dmitry. >>> >>> >>> >> >> >> Thanks for the shot :) >> >> However what is used to produced this call stack? I can imagine that a >> zf2 specific method could suffer from this regression, but I still >> have hard time to see a full app suffering from it (12%). >> >> The only reason I insist is that we already had "simply revert" in the >> past, which ended being incomplete or with mistakes, leading to much >> more critical problems. That's what I would like to prevent in stable >> releases. > Hey: > There are two options > > 1. fixed the regression based on current implementation, which > will be a little ugly.. > 2. revert it and try to make a optimization based on the previous > implementation... which obviously won't have BC break. and more safe > than 1.. > > I propose revert it in the next release, (5.4, 5.5, 5.6, and master).. > > please, lets' make it simple... the previous implementation worked well... > > > thanks >> >> >> Cheers, >> -- >> Pierre >> >> @pierrejoye | http://www.libgd.org > > > > -- > Laruence Xinchen Hui > http://www.laruence.com/ Hey: if no strongly objections,, I will revert it in next week first... thanks -- Laruence Xinchen Hui http://www.laruence.com/