Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:70504 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 5001 invoked from network); 6 Dec 2013 08:07:23 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 6 Dec 2013 08:07:23 -0000 Authentication-Results: pb1.pair.com header.from=laruence@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=laruence@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.169 as permitted sender) X-PHP-List-Original-Sender: laruence@gmail.com X-Host-Fingerprint: 209.85.217.169 mail-lb0-f169.google.com Received: from [209.85.217.169] ([209.85.217.169:40026] helo=mail-lb0-f169.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id AC/52-21332-8B581A25 for ; Fri, 06 Dec 2013 03:07:21 -0500 Received: by mail-lb0-f169.google.com with SMTP id y6so130094lbh.14 for ; Fri, 06 Dec 2013 00:07:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=clALWcDo4VTUD+7yDgNIqr45VO2fORoy+fT9fT+StuU=; b=R0qXR7bA0fS8ToezjXatQ84qcT7X0rLWvxFw28OkU+Ffty5xO7//dKoWcdpO8/OeVG 3X1Za27TY+egxFDsadItCXZGegYJDSi4oR++rKAEt4BogkXL5LYGPQhK7DCzAzs3ODtG f0SfL391bx3AwUawFuyGYMZS1saQy/WN3x7T7R7jJuIPZZmoqxt5+p84OJjbbGFKUgZR e94Jp8hDtCAdUm/JoUgYEgzmTFSaljkoQ7KFjj+NfZog9Epijw3unTwGZXCaCVsTIco2 4AgWT8khtGgMgiSzWuzpuhkhj4HRIrai+0X1CgRD80u2V9oShNbNybSApSnVJO1S/tQ5 jMZA== X-Received: by 10.112.37.134 with SMTP id y6mr490322lbj.29.1386317237306; Fri, 06 Dec 2013 00:07:17 -0800 (PST) MIME-Version: 1.0 Sender: laruence@gmail.com Received: by 10.114.157.199 with HTTP; Fri, 6 Dec 2013 00:06:57 -0800 (PST) In-Reply-To: References: <529D1197.5000305@nebm.ist.utl.pt> <8BCA5A38-788B-4E6A-A6AC-1A8DCBA3D8D9@zend.com> <759ccd0f06663defc84ffee473b51210@mail.gmail.com> <1386064737.2637.8.camel@smugmug> <1734470932732186750@unknownmsgid> Date: Fri, 6 Dec 2013 16:06:57 +0800 X-Google-Sender-Auth: 07RKLDozabkYeqSx0e0XtHvvYJY Message-ID: To: Pierre Joye Cc: Dmitry Stogov , Zeev Suraski , Andi Gutmans , PHP Internals , Hannes Magnusson , Gustavo Lopes , Mike , Gadi Goldbarg Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] strtr() performance degradation From: laruence@php.net (Laruence) On Tue, Dec 3, 2013 at 9:30 PM, Pierre Joye wrote: > hi Dmitry! > > > On Tue, Dec 3, 2013 at 12:24 PM, Dmitry Stogov wrote: >> >> ZF2 :) >> Screen-short explains it. >> >> Thanks. Dmitry. >> >> >> > > > Thanks for the shot :) > > However what is used to produced this call stack? I can imagine that a > zf2 specific method could suffer from this regression, but I still > have hard time to see a full app suffering from it (12%). > > The only reason I insist is that we already had "simply revert" in the > past, which ended being incomplete or with mistakes, leading to much > more critical problems. That's what I would like to prevent in stable > releases. Hey: There are two options 1. fixed the regression based on current implementation, which will be a little ugly.. 2. revert it and try to make a optimization based on the previous implementation... which obviously won't have BC break. and more safe than 1.. I propose revert it in the next release, (5.4, 5.5, 5.6, and master).. please, lets' make it simple... the previous implementation worked well... thanks > > > Cheers, > -- > Pierre > > @pierrejoye | http://www.libgd.org -- Laruence Xinchen Hui http://www.laruence.com/