Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:70499
Return-Path: <themattficken@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 7155 invoked from network); 4 Dec 2013 20:27:04 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 4 Dec 2013 20:27:04 -0000
Authentication-Results: pb1.pair.com smtp.mail=themattficken@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=themattficken@gmail.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.180 as permitted sender)
X-PHP-List-Original-Sender: themattficken@gmail.com
X-Host-Fingerprint: 74.125.82.180 mail-we0-f180.google.com  
Received: from [74.125.82.180] ([74.125.82.180:41105] helo=mail-we0-f180.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 09/83-15378-7109F925 for <internals@lists.php.net>; Wed, 04 Dec 2013 15:27:04 -0500
Received: by mail-we0-f180.google.com with SMTP id t61so10068888wes.11
        for <internals@lists.php.net>; Wed, 04 Dec 2013 12:27:00 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=bu56hcbH0+Zx7bAa+pWtsnKtz8cW/V/6ePpYks9mAZk=;
        b=XWUeVpvCUf1ZeRm7XcxpcYrG/aiohoftIC/JQwQWJ5BJ6I1ISzMXga0/Rh/R17dEmo
         pIljIIpPVsuq96qAcBc4w7xDQK0GiQdwl8xb46Nb6JQtiWUJgBGdtTBGYQy1P95IjUP3
         3T4u1DxKyjdOX9xWtJYf5jg9zLrBiebcA3oCk5FPa2HUCz7NRzeZPGY8IY0RCFppsVRM
         a/ZscP2pxa9I7QEiLEEcHFu91cFci2XgO3Lf4ZT93LXzTjZu3+3+Boc1eWPXcWsUsJ4y
         UdiATN0csv3r/80uYnY4nLTkpMsOC2T7EB23DdXh30H/0jvyQ/aE5Xi/CFkw7fkDGJBF
         hmxQ==
MIME-Version: 1.0
X-Received: by 10.180.228.132 with SMTP id si4mr2105858wic.2.1386188820029;
 Wed, 04 Dec 2013 12:27:00 -0800 (PST)
Received: by 10.194.85.165 with HTTP; Wed, 4 Dec 2013 12:26:59 -0800 (PST)
In-Reply-To: <3723aa16373647e5ad01f33992ac4c9c@BLUPR03MB421.namprd03.prod.outlook.com>
References: <3723aa16373647e5ad01f33992ac4c9c@BLUPR03MB421.namprd03.prod.outlook.com>
Date: Wed, 4 Dec 2013 12:26:59 -0800
Message-ID: <CAMbn9ZEBbOHtaQmfgJRaYpwPsNdRgexCYcmkFz7iFY4HXNYuVg@mail.gmail.com>
To: Eric Stenson <ericsten@microsoft.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>, Pierre Joye <pierre.php@gmail.com>
Content-Type: multipart/alternative; boundary=001a1136129e35a60404ecbb3c00
Subject: Re: [PHP-DEV] Patch: Fixing some .phpt's that fail with Wincache
From: themattficken@gmail.com (Matt Ficken)

--001a1136129e35a60404ecbb3c00
Content-Type: text/plain; charset=ISO-8859-1

On Mon, Nov 25, 2013 at 11:15 AM, Eric Stenson <ericsten@microsoft.com>wrote:

>  Internals folks:
>
>
>
> Attached is a patch that includes fixes to some .phpt files that are
> failing when Wincache is enabled.  The patch is against the PHP-5.6 branch.
>


I can't reproduce any of these test failures with wincacheu on 5.6, either
with opcache or with no code cache (either with PFTT or run-tests).

I am using 5.6 r1205a6c x64 with the wincache DLL you gave me, on Win7 x64.

This is the wincache snippet of the INI I am using:
wincache.enablecli=1
wincache.ocenabled=0
wincache.fcenabled=1
wincache.ucenabled=1
extension=php_wincache.dll
zend_extension=<path to opcache dll>


What configuration are you using to run these (Win version, php build, INI,
etc...) ?



>
>
> The failures occur because the tests are coded to expect specific resource
> IDs.  However, when Wincache is loaded, it takes a few resource objects
> "off-the-top".  This causes these tests to erroneously fail.
>
>
>
> There isn't a bug filed for these; I am starting work on the PHP-5.6/x64
> stuff, and wanted to get the pass rate to match the results when Wincache
> wasn't loaded.
>
>
>
> Please review & consider for inclusion in the PHP project.
>
>
>
> Thx!
>
>     --E.
>
>
>
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>

--001a1136129e35a60404ecbb3c00--