Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:70491
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.176 as permitted sender)
Message-ID: <529DD60C.30601@gmail.com>
Date: Tue, 03 Dec 2013 13:01:00 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1
MIME-Version: 1.0
To: Derick Rethans <derick@php.net>
CC: PHP Internals <internals@lists.php.net>
References: <528CE64A.1020303@gmail.com> <alpine.DEB.2.10.1312031016190.7994@whisky.home.derickrethans.nl>
In-Reply-To: <alpine.DEB.2.10.1312031016190.7994@whisky.home.derickrethans.nl>
Content-Type: multipart/alternative;
 boundary="------------040607090000010602070409"
Subject: Re: [PHP-DEV] Comments on non-unique naming convention for closures
From: ellison.terry@gmail.com (Terry Ellison)

--------------040607090000010602070409
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Hi Derick,
>
>> What I am suggesting is that this convention should be changed for something
>> like "\0{closure}$name$ctime$index" or even just "\0{closure}$uuid" using the
>> standard UUID algo.  Reactions? Comments?
> For Xdebug to show them in stack traces, and for profiling, I rewrite
> them to: {closure:/path/to/closure-stack-trace.php:4-7}
> Seehttps://github.com/xdebug/xdebug/blob/master/xdebug_stack.c#L909

Thanks for this.  What you are rewriting here is the function name of 
the closure being executed and which is the backtrace.  As I said in my 
O/P, the closure contains a deep copy of the magic-named version stored 
in the EG function table.  The closure copy is always called {closure} 
at the moment, but the original version has this supposedly unique magic 
name that I now want to make unique.  Hence we have two separate issues:

* What do we name the zend_function structure in the closure object?  As 
you suggest, it would make a lot of sense here to make this meaningful 
to the programmer so {closure:<filename>:<start-line>-<end-line>} is a 
lot better than the current {closure}.  Hoisting your approach into 
zend_closures.c would make a lot of sense.  Note that this name doesn't 
need to be unique.

* What do we call the template copy in the EG function table? This is 
never exposed to the programmer, so it's name is unimportant in these 
terms, but it should be unique for a given closure source.

Regards Terry


--------------040607090000010602070409--