Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:70484
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.178 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <759ccd0f06663defc84ffee473b51210@mail.gmail.com>
References: <CA+9eiLuSBF9NVqnGV8Oe1Dn-tBQ_86h2PGsFuJhr0_Wv9jYoZg@mail.gmail.com>
	<op.wx532ugqidpuyk@damnation.nl.lo.geleia.net>
	<CA+9eiLtpKjJtF9K7xBnftmzjEd92C6rLu-k+0RW1wfc60_oLtg@mail.gmail.com>
	<op.wx6g9ftzidpuyk@damnation.nl.lo.geleia.net>
	<CABBJUpdvzkO-p6mKtGnrrxdAvXgRp8GHzEGazjibCSicOgS9Eg@mail.gmail.com>
	<529D1197.5000305@nebm.ist.utl.pt>
	<8BCA5A38-788B-4E6A-A6AC-1A8DCBA3D8D9@zend.com>
	<CADNQb0XtN2zeLEb-bGm5L6rfH+7KomOVgmqaxwp4fQcceOMcgQ@mail.gmail.com>
	<759ccd0f06663defc84ffee473b51210@mail.gmail.com>
Date: Tue, 3 Dec 2013 10:15:26 +0100
Message-ID: <CAEZPtU4CKnhLsF0qk3FtFBRJ95VYyEjxui24_2ajNn-Mv+7XOA@mail.gmail.com>
To: Zeev Suraski <zeev@zend.com>
Cc: Hannes Magnusson <hannes.magnusson@gmail.com>, Andi Gutmans <andi@zend.com>, 
	Gustavo Lopes <glopes@nebm.ist.utl.pt>, Laruence <laruence@php.net>, 
	Dmitry Stogov <dmitry@zend.com>, PHP Internals <internals@lists.php.net>, Gadi Goldbarg <gadi@zend.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] strtr() performance degradation
From: pierre.php@gmail.com (Pierre Joye)

On Tue, Dec 3, 2013 at 9:29 AM, Zeev Suraski <zeev@zend.com> wrote:

> To put things in perspective, the work that goes into improving PHP's
> performance by 10% is measured in months, sometimes more (from inception to
> production).  Here, we have a patch that slowed real world apps (not
> synthetic benchmarks) by over 10%, and despite the fact it was reported 6
> months ago, we've done absolutely nothing about it.  If anything in that
> story doesn't make sense, that would be it.

I cannot agree more than performance is part of the CI/QA process and
should be taken as blocker on release time (if any regressions are
noticed). We do that on a daily basis for every commit and alerts are
sent if there is a performance impact superior to 1-3%.

However I have hard time to imagine than strstr alone can reduce real
apps performance by 10%, unless we are talking about one single module
using it intensively. Do you have numbers and the way you tested it
pls?

> We should revert this patch ASAP;  It's unfortunate we haven't done it back
> when it was found but better late than never.

I'm not too fund to revert in stable series. But I'm fine to revert it
for 5.6.0 if the performance impact has not been solved by the time we
will release the final release. Once it is out (optimized back or
reverted), we can always consider it for 5.5 or eventually 5.4.

Cheers,
-- 
Pierre

@pierrejoye | http://www.libgd.org