Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:70478
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain zend.com from 209.85.212.175 cause and error)
MIME-Version: 1.0
In-Reply-To: <CADNQb0XtN2zeLEb-bGm5L6rfH+7KomOVgmqaxwp4fQcceOMcgQ@mail.gmail.com>
References: <CA+9eiLuSBF9NVqnGV8Oe1Dn-tBQ_86h2PGsFuJhr0_Wv9jYoZg@mail.gmail.com>
	<op.wx532ugqidpuyk@damnation.nl.lo.geleia.net>
	<CA+9eiLtpKjJtF9K7xBnftmzjEd92C6rLu-k+0RW1wfc60_oLtg@mail.gmail.com>
	<op.wx6g9ftzidpuyk@damnation.nl.lo.geleia.net>
	<CABBJUpdvzkO-p6mKtGnrrxdAvXgRp8GHzEGazjibCSicOgS9Eg@mail.gmail.com>
	<529D1197.5000305@nebm.ist.utl.pt>
	<8BCA5A38-788B-4E6A-A6AC-1A8DCBA3D8D9@zend.com>
	<CADNQb0XtN2zeLEb-bGm5L6rfH+7KomOVgmqaxwp4fQcceOMcgQ@mail.gmail.com>
Date: Tue, 3 Dec 2013 11:59:16 +0400
Message-ID: <CA+9eiLsFFgDinS3TC248BTV9Q=QuSt2C0Ro54CRvJiSPj=Ykuw@mail.gmail.com>
To: Hannes Magnusson <hannes.magnusson@gmail.com>
Cc: Andi Gutmans <andi@zend.com>, Gustavo Lopes <glopes@nebm.ist.utl.pt>, Laruence <laruence@php.net>, 
	PHP Internals <internals@lists.php.net>, Zeev Suraski <zeev@zend.com>, Gadi Goldbarg <gadi@zend.com>
Content-Type: multipart/alternative; boundary=047d7bb04a1246d1d904ec9cac42
Subject: Re: [PHP-DEV] strtr() performance degradation
From: dmitry@zend.com (Dmitry Stogov)

--047d7bb04a1246d1d904ec9cac42
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

At least it must be fixed in PHP-5.6 and measured what kind of performance
degradation we got in 5.4.
Then we may think if it makes sense to apply it to 5.4 and 5.5.
It's always dangerous, but significant speed difference on real life
applications matters.

Thanks. Dmitry.


On Tue, Dec 3, 2013 at 11:33 AM, Hannes Magnusson <
hannes.magnusson@gmail.com> wrote:

> On Mon, Dec 2, 2013 at 10:54 PM, Andi Gutmans <andi@zend.com> wrote:
> >
> > On Dec 2, 2013, at 3:02 PM, Gustavo Lopes <glopes@nebm.ist.utl.pt>
> wrote:
> >>> =E2=89=88
> >>
> >> The progress consists of writing of scripts to test the point where to
> switch algorithms and trying some improvements on the old one without as
> expensive preprocessing steps.
> >>
> >> Now, this was in the summer... I'll have some time in the holidays to
> pick up this and some other PHP-related backlog; that said, if there's so=
me
> impatience (which would be perfectly understandable...), I wouldn't mind =
if
> someone reverted to the previous state in the meantime.
> >
> > Sounds like this may take some time to figure out. So if there is
> absolutely no difference in semantics between the two I would suggest we
> revert until you are able to dig into this.
> >
>
>
> This change was included in 5.4.12 and 5.4.22 has been released.
> Now you want to revert and maybe release 5.4.23 and then apply again in
> 5.4.24?
>
> That doesn't seem worth it. What done is done. Had it been reverted
> right away then it would have make sense, but not 10 releases later?
>
> -Hannes
>

--047d7bb04a1246d1d904ec9cac42--