Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:70463
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAHMUw2HaoKFMWkU2Aw5X5d+eKddQHkv0ZHhb_dDb5YBDg=M+0Q@mail.gmail.com>
References: <CAHMUw2HaoKFMWkU2Aw5X5d+eKddQHkv0ZHhb_dDb5YBDg=M+0Q@mail.gmail.com>
Date: Mon, 2 Dec 2013 16:24:13 +0800
Message-ID: <CAHMUw2FOQvQSZ6xjLDShdKcie3QGrUhMHnSiP8-evrzb2iNdCA@mail.gmail.com>
To: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bdc8f1ab2db9304ec88e7bf
Subject: Re: Fixes for curl_setopt() and nullable values
From: tjerk.meesters@gmail.com (Tjerk Meesters)

--047d7bdc8f1ab2db9304ec88e7bf
Content-Type: text/plain; charset=ISO-8859-1

On Wed, Nov 27, 2013 at 4:29 PM, Tjerk Meesters <tjerk.meesters@gmail.com>wrote:

> Hi,
>
> A few weeks ago I stumbled upon the following question on stackoverflow:
>
>
> http://stackoverflow.com/questions/4163865/how-to-reset-curlopt-customrequest
>
> It involves the CURLOPT_CUSTOMREQUEST option, which according to the
> libcurl documentation can be set to NULL to restore the previous behaviour
> of passing the method name based on the type of request.
>
> However, for string-based options the current code converts a NULL value
> into an empty string, so it's impossible to revert the behaviour.
>
> After doing a quick hack I realized that there are more options that are
> nullable, so I've decided to refactor some of the code to isolate the
> string assignment; this makes adding future nullable options easier.
>
> This is the pull request: https://github.com/php/php-src/pull/531
>
> It passes the test cases on my machine (couldn't test all of them because
> file uploads aren't supported when you use internal web server), but I
> would appreciate a second look.
>

I've made some tweaks based on Stanislav's suggestions.

If there are no further objections, could someone merge this to master or
give me (datibbaw) the required karma to do so? Thanks ^_^


-- 
--
Tjerk

--047d7bdc8f1ab2db9304ec88e7bf--