Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:70452
Return-Path: <smalyshev@sugarcrm.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 58326 invoked from network); 30 Nov 2013 03:46:36 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 30 Nov 2013 03:46:36 -0000
Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 108.166.43.115 as permitted sender)
X-PHP-List-Original-Sender: smalyshev@sugarcrm.com
X-Host-Fingerprint: 108.166.43.115 smtp115.ord1c.emailsrvr.com Linux 2.6
Received: from [108.166.43.115] ([108.166.43.115:51869] helo=smtp115.ord1c.emailsrvr.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 01/93-29842-A9F59925 for <internals@lists.php.net>; Fri, 29 Nov 2013 22:46:36 -0500
Received: from localhost (localhost.localdomain [127.0.0.1])
	by smtp7.relay.ord1c.emailsrvr.com (SMTP Server) with ESMTP id B1F3C1B83BF;
	Fri, 29 Nov 2013 22:46:32 -0500 (EST)
X-Virus-Scanned: OK
Received: by smtp7.relay.ord1c.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id 249B21B83B4;
	Fri, 29 Nov 2013 22:46:32 -0500 (EST)
Message-ID: <52995F97.7000901@sugarcrm.com>
Date: Fri, 29 Nov 2013 19:46:31 -0800
Organization: SugarCRM
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:24.0) Gecko/20100101 Thunderbird/24.1.1
MIME-Version: 1.0
To: Terry Ellison <ellison.terry@gmail.com>, 
 PHP Internals <internals@lists.php.net>
CC: Joe Watkins <krakjoe@php.net>, "arjen@react.com" <arjen@react.com>, 
 Ferenc Kovacs <tyra3l@gmail.com>
References: <528CE64A.1020303@gmail.com> <CAH-PCH5RP1HRzC+qz94B862zrPt5O3x=U7MDvJJDPOJmAEkPjg@mail.gmail.com> <528EA006.2090400@gmail.com> <52993190.4010905@gmail.com>
In-Reply-To: <52993190.4010905@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Comments on non-unique naming convention for closures
From: smalyshev@sugarcrm.com (Stas Malyshev)

Hi!

> Having discussed the options with Dmitry and another contributor off PHP 
> Internals list, we have decided to base the generated <internal> 
> function name on a hash of the source content between the text pointers 

Wouldn't that imply that two closures with the same code would be
identified as the same closure? If so, I'm not sure this is a correct
approach - one can definitely have two different closures (with
different states, different bindings, etc.) having same source text. Or
am I missing something here?

-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227