Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:70412
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain microsoft.com designates 207.46.163.237 as permitted sender)
To: Tjerk Meesters <tjerk.meesters@gmail.com>, Ferenc Kovacs
	<tyra3l@gmail.com>
CC: Nikita Popov <nikita.ppv@gmail.com>, "internals@lists.php.net"
	<internals@lists.php.net>, Pierre Joye <pierre.php@gmail.com>
Thread-Topic: [PHP-DEV] RE: Patch: Fixing some .phpt's that fail with
 Wincache
Thread-Index: Ac7qEf1rAkElSMukSJS7efsl8cTrvAAAreGgABcTn4AABeLOgAAAzjyAABAc6OA=
Date: Tue, 26 Nov 2013 17:35:41 +0000
Message-ID: <9095b88708ea45cbbaffdcf645b96450@BLUPR03MB421.namprd03.prod.outlook.com>
References: <3723aa16373647e5ad01f33992ac4c9c@BLUPR03MB421.namprd03.prod.outlook.com>
	<6e85635635da4ac193a5ba309d4dbd96@BLUPR03MB421.namprd03.prod.outlook.com>
	<CAF+90c9zmwKgpW97n=iUw7r4oQ1CU+5Y9E+WAs5X3ztt+4yTqg@mail.gmail.com>
	<CAH-PCH7k2fsZNEXEieZxpAK5oZwTZPmEtPLbpXRs1VW=5_P4+g@mail.gmail.com>
 <CAHMUw2HMYhLgokxP2TZ3sVKrph3PNHEbQ-tLuD8QWfmVau4JLQ@mail.gmail.com>
In-Reply-To: <CAHMUw2HMYhLgokxP2TZ3sVKrph3PNHEbQ-tLuD8QWfmVau4JLQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: multipart/alternative;
	boundary="_000_9095b88708ea45cbbaffdcf645b96450BLUPR03MB421namprd03pro_"
MIME-Version: 1.0
Subject: RE: [PHP-DEV] RE: Patch: Fixing some .phpt's that fail with Wincache
From: ericsten@microsoft.com (Eric Stenson)

--_000_9095b88708ea45cbbaffdcf645b96450BLUPR03MB421namprd03pro_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

From: Tjerk Meesters [mailto:tjerk.meesters@gmail.com]
Sent: Tuesday, November 26, 2013 1:42 AM

> On Tue, Nov 26, 2013 at 5:19 PM, Ferenc Kovacs <tyra3l@gmail.com<mailto:t=
yra3l@gmail.com>> wrote:
> 2013.11.26. 7:31, "Nikita Popov" <nikita.ppv@gmail.com<mailto:nikita.ppv@=
gmail.com>> ezt =EDrta:
> >
> > On Mon, Nov 25, 2013 at 8:30 PM, Eric Stenson <ericsten@microsoft.com<m=
ailto:ericsten@microsoft.com>
> >wrote:
[...]
> > >  $ui1 =3D uniqid($str);
> > > +/* Must sleep here to let uniqid generate a different unique ID */
> > > +usleep( 10 );
> > >  $ui2 =3D uniqid($str);
> > >
> > >  $len =3D strncasecmp(PHP_OS, 'CYGWIN', 6) ? 19 : 29;
> > >
>
> Internally, uniqid() uses usleep(1) only if 'more entropy' is omitted and=
 not on Windows and Cygwin (must use 'more entropy').
>
> So, when 'more entropy' is present, it will skip usleep(1) but pad the re=
sult with php_combined_lcg().
>
> I'm sure there was a good reason to do so, but it does seem counter-intui=
tive at best.
>

Ah!  My bad.  Please remove the usleep(10) and add the ', true' (more entro=
py) param to the uniqid() call.  This test consistently fails on Windows.

For completeness of coverage, you might consider also testing with the usle=
ep(1) and without the ', true' (more entropy) param.

Thx!
     --E.

--_000_9095b88708ea45cbbaffdcf645b96450BLUPR03MB421namprd03pro_--