Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:70396
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.176 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAH-PCH7k2fsZNEXEieZxpAK5oZwTZPmEtPLbpXRs1VW=5_P4+g@mail.gmail.com>
References: <3723aa16373647e5ad01f33992ac4c9c@BLUPR03MB421.namprd03.prod.outlook.com>
	<6e85635635da4ac193a5ba309d4dbd96@BLUPR03MB421.namprd03.prod.outlook.com>
	<CAF+90c9zmwKgpW97n=iUw7r4oQ1CU+5Y9E+WAs5X3ztt+4yTqg@mail.gmail.com>
	<CAH-PCH7k2fsZNEXEieZxpAK5oZwTZPmEtPLbpXRs1VW=5_P4+g@mail.gmail.com>
Date: Tue, 26 Nov 2013 17:42:11 +0800
Message-ID: <CAHMUw2HMYhLgokxP2TZ3sVKrph3PNHEbQ-tLuD8QWfmVau4JLQ@mail.gmail.com>
To: Ferenc Kovacs <tyra3l@gmail.com>
Cc: Nikita Popov <nikita.ppv@gmail.com>, 
	"internals@lists.php.net" <internals@lists.php.net>, Eric Stenson <ericsten@microsoft.com>, 
	Pierre Joye <pierre.php@gmail.com>
Content-Type: multipart/alternative; boundary=001a11c3bea06fe23b04ec114b36
Subject: Re: [PHP-DEV] RE: Patch: Fixing some .phpt's that fail with Wincache
From: tjerk.meesters@gmail.com (Tjerk Meesters)

--001a11c3bea06fe23b04ec114b36
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 26, 2013 at 5:19 PM, Ferenc Kovacs <tyra3l@gmail.com> wrote:

> 2013.11.26. 7:31, "Nikita Popov" <nikita.ppv@gmail.com> ezt =EDrta:
> >
> > On Mon, Nov 25, 2013 at 8:30 PM, Eric Stenson <ericsten@microsoft.com
> >wrote:
> >
> > > diff --git a/ext/standard/tests/strings/implode1.phpt
> > > b/ext/standard/tests/strings/implode1.phpt
> > > index
> > >
>
> 3997c54b59eb3b86777b64b58f7ce67f25acac55..3720c069276784a1b588da672f9731c=
89b4e5fb7
> > > 100644
> > > GIT binary patch
> > > delta 32
> > > ncmeyY`&D<tb`fFK6f3Ks)Z+ZoqU2PC%oGJ>)s)RAM6{Uz()tUF
> > >
> > > delta 30
> > > lcmeyW`&oCxb`e2SE32T?;{4L0<Wz;s6a{6o&8I}PnE<>^3giF)
> > >
> >
> > What's being changed here?
> >
> > diff --git a/tests/strings/001.phpt b/tests/strings/001.phpt
> > > index 3bfd3db..7b61835 100644
> > > --- a/tests/strings/001.phpt
> > > +++ b/tests/strings/001.phpt
> > > @@ -180,6 +180,8 @@ if ($ss =3D=3D "\$'") {
> > >  echo "Testing uniqid: ";
> > >  $str =3D "prefix";
> > >  $ui1 =3D uniqid($str);
> > > +/* Must sleep here to let uniqid generate a different unique ID */
> > > +usleep( 10 );
> > >  $ui2 =3D uniqid($str);
> > >
> > >  $len =3D strncasecmp(PHP_OS, 'CYGWIN', 6) ? 19 : 29;
> > >
> >
> > Not sure this is right. uniqid() should generate different IDs even whe=
n
> > there are two subsequent calls. If it doesn't, that sounds like a bug.
> >
> > Nikita
>
> Only if the time is different, and AFAIR some platforms(like win) has les=
s
> microtime precision, which could cause problems like that.
> But there is a more entropy param for uniqid, maybe that would be a bette=
r
> solution than sleep.
>

Internally, uniqid() uses usleep(1) only if 'more entropy' is omitted and
not on Windows and Cygwin (must use 'more entropy').

So, when 'more entropy' is present, it will skip usleep(1) but pad the
result with php_combined_lcg().

I'm sure there was a good reason to do so, but it does seem
counter-intuitive at best.



--=20
--
Tjerk

--001a11c3bea06fe23b04ec114b36--