Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:70394 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 14647 invoked from network); 26 Nov 2013 09:19:11 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 26 Nov 2013 09:19:11 -0000 Authentication-Results: pb1.pair.com header.from=tyra3l@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=tyra3l@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.44 as permitted sender) X-PHP-List-Original-Sender: tyra3l@gmail.com X-Host-Fingerprint: 209.85.128.44 mail-qe0-f44.google.com Received: from [209.85.128.44] ([209.85.128.44:61461] helo=mail-qe0-f44.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 75/F0-08401-D8764925 for ; Tue, 26 Nov 2013 04:19:10 -0500 Received: by mail-qe0-f44.google.com with SMTP id nd7so4658772qeb.17 for ; Tue, 26 Nov 2013 01:19:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=ZA3TZFZGF2+GtnnjSf81gb6z0CL7ME0A6qHxNqKUr+o=; b=MXSsB+bYT2eYR5n7p4dINd6ni4/KeD5Oku1BWZ/KuVNiO3zhSBdmFRldTPqEdotE6E QbY8kvnjdZvV37NFXqFXYuurNLFlRlmJ2FYP7igCCy6DjCqyRIqB60MW3hjB9aTtdQe0 RL4Li9LmGDlPCVM813ZqXbtQ6e4VVPoDyQpsY7f6uacPdr96y1eVvWsQ3HcgmUoMx4SS CfUmdWlP2kfsE/6fi315D+/APxejyT8vxSplcqH+2MprSazxTJKb4j7a4DRbUKFYWJtI 2q/3IlQI2k4cD5aX5m2dqE6YKMqrBHxbMFqwM4z89TgwpcUEJdJAgwmrrDu/nEhDMKTh SKGg== MIME-Version: 1.0 X-Received: by 10.229.65.201 with SMTP id k9mr53749861qci.11.1385457547082; Tue, 26 Nov 2013 01:19:07 -0800 (PST) Received: by 10.140.37.179 with HTTP; Tue, 26 Nov 2013 01:19:07 -0800 (PST) Received: by 10.140.37.179 with HTTP; Tue, 26 Nov 2013 01:19:07 -0800 (PST) In-Reply-To: References: <3723aa16373647e5ad01f33992ac4c9c@BLUPR03MB421.namprd03.prod.outlook.com> <6e85635635da4ac193a5ba309d4dbd96@BLUPR03MB421.namprd03.prod.outlook.com> Date: Tue, 26 Nov 2013 10:19:07 +0100 Message-ID: To: Nikita Popov Cc: "internals@lists.php.net" , Eric Stenson , Pierre Joye Content-Type: multipart/alternative; boundary=001a1133a002f2019a04ec10f8bb Subject: Re: [PHP-DEV] RE: Patch: Fixing some .phpt's that fail with Wincache From: tyra3l@gmail.com (Ferenc Kovacs) --001a1133a002f2019a04ec10f8bb Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable 2013.11.26. 7:31, "Nikita Popov" ezt =C3=ADrta: > > On Mon, Nov 25, 2013 at 8:30 PM, Eric Stenson wrote: > > > diff --git a/ext/standard/tests/strings/implode1.phpt > > b/ext/standard/tests/strings/implode1.phpt > > index > > 3997c54b59eb3b86777b64b58f7ce67f25acac55..3720c069276784a1b588da672f9731c89= b4e5fb7 > > 100644 > > GIT binary patch > > delta 32 > > ncmeyY`&D)s)RAM6{Uz()tUF > > > > delta 30 > > lcmeyW`&oCxb`e2SE32T?;{4L0^3giF) > > > > What's being changed here? > > diff --git a/tests/strings/001.phpt b/tests/strings/001.phpt > > index 3bfd3db..7b61835 100644 > > --- a/tests/strings/001.phpt > > +++ b/tests/strings/001.phpt > > @@ -180,6 +180,8 @@ if ($ss =3D=3D "\$'") { > > echo "Testing uniqid: "; > > $str =3D "prefix"; > > $ui1 =3D uniqid($str); > > +/* Must sleep here to let uniqid generate a different unique ID */ > > +usleep( 10 ); > > $ui2 =3D uniqid($str); > > > > $len =3D strncasecmp(PHP_OS, 'CYGWIN', 6) ? 19 : 29; > > > > Not sure this is right. uniqid() should generate different IDs even when > there are two subsequent calls. If it doesn't, that sounds like a bug. > > Nikita Only if the time is different, and AFAIR some platforms(like win) has less microtime precision, which could cause problems like that. But there is a more entropy param for uniqid, maybe that would be a better solution than sleep. --001a1133a002f2019a04ec10f8bb--