Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:70392
Return-Path: <nikita.ppv@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 6032 invoked from network); 26 Nov 2013 06:30:39 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 26 Nov 2013 06:30:39 -0000
Authentication-Results: pb1.pair.com smtp.mail=nikita.ppv@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=nikita.ppv@gmail.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.44 as permitted sender)
X-PHP-List-Original-Sender: nikita.ppv@gmail.com
X-Host-Fingerprint: 209.85.219.44 mail-oa0-f44.google.com  
Received: from [209.85.219.44] ([209.85.219.44:62387] helo=mail-oa0-f44.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 79/51-33497-E0044925 for <internals@lists.php.net>; Tue, 26 Nov 2013 01:30:39 -0500
Received: by mail-oa0-f44.google.com with SMTP id m1so5591389oag.3
        for <internals@lists.php.net>; Mon, 25 Nov 2013 22:30:35 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=XSYKmgT34wtEy31b+CsCW97FoT33cSDJetyKWG8Q5JE=;
        b=cHlmkJeelQEhALno9n1IsOXyLbjr7TaP3iF73ayKHadkQKF9TmUE3O90bUN/K/Xwwp
         ZvdMqNL7BxdE9vFwN2sdRKpeclqVi9h2+8NjKJ7EnbqUQG6OfqUi1RYdjz1plYRMb8oB
         cMzuXwjOsSRX+PhlHyy3v4vsBhef+TU/+6+E4D5jPWiSY73FDThTj+Wac5ip3mexw4QT
         iJzZgdh+ywhmFFShJth0sIPNE5e3RFF2IGjY8t82bRcXEvOz2wCyDsAxXCtxThbwoSIU
         8A0FCgWTHYOBo6Hn4D5vwIRviU7HapqFAUDuYvkV26Fg1UKPC3ddiK75A+HOHgX1kc6I
         LPdg==
MIME-Version: 1.0
X-Received: by 10.60.147.130 with SMTP id tk2mr5775626oeb.25.1385447435177;
 Mon, 25 Nov 2013 22:30:35 -0800 (PST)
Received: by 10.182.54.112 with HTTP; Mon, 25 Nov 2013 22:30:35 -0800 (PST)
In-Reply-To: <6e85635635da4ac193a5ba309d4dbd96@BLUPR03MB421.namprd03.prod.outlook.com>
References: <3723aa16373647e5ad01f33992ac4c9c@BLUPR03MB421.namprd03.prod.outlook.com>
	<6e85635635da4ac193a5ba309d4dbd96@BLUPR03MB421.namprd03.prod.outlook.com>
Date: Tue, 26 Nov 2013 07:30:35 +0100
Message-ID: <CAF+90c9zmwKgpW97n=iUw7r4oQ1CU+5Y9E+WAs5X3ztt+4yTqg@mail.gmail.com>
To: Eric Stenson <ericsten@microsoft.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>, Pierre Joye <pierre.php@gmail.com>
Content-Type: multipart/alternative; boundary=047d7b3a80fc3a94fd04ec0e9e81
Subject: Re: [PHP-DEV] RE: Patch: Fixing some .phpt's that fail with Wincache
From: nikita.ppv@gmail.com (Nikita Popov)

--047d7b3a80fc3a94fd04ec0e9e81
Content-Type: text/plain; charset=ISO-8859-1

On Mon, Nov 25, 2013 at 8:30 PM, Eric Stenson <ericsten@microsoft.com>wrote:

> diff --git a/ext/standard/tests/strings/implode1.phpt
> b/ext/standard/tests/strings/implode1.phpt
> index
> 3997c54b59eb3b86777b64b58f7ce67f25acac55..3720c069276784a1b588da672f9731c89b4e5fb7
> 100644
> GIT binary patch
> delta 32
> ncmeyY`&D<tb`fFK6f3Ks)Z+ZoqU2PC%oGJ>)s)RAM6{Uz()tUF
>
> delta 30
> lcmeyW`&oCxb`e2SE32T?;{4L0<Wz;s6a{6o&8I}PnE<>^3giF)
>

What's being changed here?

diff --git a/tests/strings/001.phpt b/tests/strings/001.phpt
> index 3bfd3db..7b61835 100644
> --- a/tests/strings/001.phpt
> +++ b/tests/strings/001.phpt
> @@ -180,6 +180,8 @@ if ($ss == "\$'") {
>  echo "Testing uniqid: ";
>  $str = "prefix";
>  $ui1 = uniqid($str);
> +/* Must sleep here to let uniqid generate a different unique ID */
> +usleep( 10 );
>  $ui2 = uniqid($str);
>
>  $len = strncasecmp(PHP_OS, 'CYGWIN', 6) ? 19 : 29;
>

Not sure this is right. uniqid() should generate different IDs even when
there are two subsequent calls. If it doesn't, that sounds like a bug.

Nikita

--047d7b3a80fc3a94fd04ec0e9e81--