Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:70385 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 58651 invoked from network); 25 Nov 2013 19:16:12 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 25 Nov 2013 19:16:12 -0000 Authentication-Results: pb1.pair.com smtp.mail=ericsten@microsoft.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=ericsten@microsoft.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain microsoft.com designates 207.46.163.206 as permitted sender) X-PHP-List-Original-Sender: ericsten@microsoft.com X-Host-Fingerprint: 207.46.163.206 mail-bl2lp0206.outbound.protection.outlook.com Received: from [207.46.163.206] ([207.46.163.206:12300] helo=na01-bl2-obe.outbound.protection.outlook.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id B9/2A-34377-9F1A3925 for ; Mon, 25 Nov 2013 14:16:10 -0500 Received: from BLUPR03MB421.namprd03.prod.outlook.com (10.141.78.140) by BLUPR03MB424.namprd03.prod.outlook.com (10.141.78.152) with Microsoft SMTP Server (TLS) id 15.0.820.5; Mon, 25 Nov 2013 19:16:00 +0000 Received: from BLUPR03MB421.namprd03.prod.outlook.com ([10.141.78.140]) by BLUPR03MB421.namprd03.prod.outlook.com ([10.141.78.140]) with mapi id 15.00.0820.005; Mon, 25 Nov 2013 19:15:59 +0000 To: "'internals@lists.php.net'" CC: Pierre Joye Thread-Topic: Patch: Fixing some .phpt's that fail with Wincache Thread-Index: Ac7qEf1rAkElSMukSJS7efsl8cTrvA== Date: Mon, 25 Nov 2013 19:15:59 +0000 Message-ID: <3723aa16373647e5ad01f33992ac4c9c@BLUPR03MB421.namprd03.prod.outlook.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-originating-ip: [2001:4898:80e8:ee31::2] x-forefront-prvs: 0041D46242 x-forefront-antispam-report: SFV:NSPM;SFS:(43234003)(199002)(189002)(51856001)(74502001)(80976001)(54356001)(79102001)(87936001)(53806001)(81542001)(47736001)(49866001)(50986001)(4396001)(47446002)(87266001)(80022001)(83322001)(46102001)(76482001)(63696002)(76176001)(77982001)(33646001)(76786001)(76796001)(15975445006)(76576001)(83072001)(15202345003)(59766001)(69226001)(81686001)(19580395003)(74316001)(81342001)(2656002)(47976001)(65816001)(74366001)(74662001)(19300405004)(31966008)(56776001)(19609705001)(85306002)(81816001)(74706001)(16236675002)(54316002)(56816003)(74876001)(142923001)(24736002)(3826001)(491001);DIR:OUT;SFP:;SCL:1;SRVR:BLUPR03MB424;H:BLUPR03MB421.namprd03.prod.outlook.com;CLIP:2001:4898:80e8:ee31::2;FPR:;RD:InfoNoRecords;A:1;MX:1;LANG:en; Content-Type: multipart/mixed; boundary="_004_3723aa16373647e5ad01f33992ac4c9cBLUPR03MB421namprd03pro_" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com Subject: Patch: Fixing some .phpt's that fail with Wincache From: ericsten@microsoft.com (Eric Stenson) --_004_3723aa16373647e5ad01f33992ac4c9cBLUPR03MB421namprd03pro_ Content-Type: multipart/alternative; boundary="_000_3723aa16373647e5ad01f33992ac4c9cBLUPR03MB421namprd03pro_" --_000_3723aa16373647e5ad01f33992ac4c9cBLUPR03MB421namprd03pro_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Internals folks: Attached is a patch that includes fixes to some .phpt files that are failin= g when Wincache is enabled. The patch is against the PHP-5.6 branch. The failures occur because the tests are coded to expect specific resource = IDs. However, when Wincache is loaded, it takes a few resource objects "of= f-the-top". This causes these tests to erroneously fail. There isn't a bug filed for these; I am starting work on the PHP-5.6/x64 st= uff, and wanted to get the pass rate to match the results when Wincache was= n't loaded. Please review & consider for inclusion in the PHP project. Thx! --E. --_000_3723aa16373647e5ad01f33992ac4c9cBLUPR03MB421namprd03pro_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Internals folks:

 

Attached is a patch that i= ncludes fixes to some .phpt files that are failing when Wincache is enabled= .  The patch is against the PHP-5.6 branch.

 

The failures occur because= the tests are coded to expect specific resource IDs.  However, when W= incache is loaded, it takes a few resource objects "off-the-top".=   This causes these tests to erroneously fail.

 

There isn't a bug filed fo= r these; I am starting work on the PHP-5.6/x64 stuff, and wanted to get the= pass rate to match the results when Wincache wasn't loaded.

 

Please review & consid= er for inclusion in the PHP project.

 

Thx!

    --E.

 

 

--_000_3723aa16373647e5ad01f33992ac4c9cBLUPR03MB421namprd03pro_-- --_004_3723aa16373647e5ad01f33992ac4c9cBLUPR03MB421namprd03pro_--