Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:70360
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.44 as permitted sender)
MIME-Version: 1.0
Sender: jakub.php@gmail.com
In-Reply-To: <ac356e6f51447e9d17b12e4916135e68.squirrel@webmail.klapt.com>
References: <ac356e6f51447e9d17b12e4916135e68.squirrel@webmail.klapt.com>
Date: Sun, 24 Nov 2013 21:21:36 +0000
Message-ID: <CAEKnhAG-SvNpQ5iHdFDL7nf5=8j+H+2jgYE+wX-qq+hjJMJ0kw@mail.gmail.com>
To: Anatol Belski <ab@php.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c2bd841c141204ebf2d59a
Subject: Re: [PHP-DEV] size_t and 64 bit integer branch
From: bukka@php.net (Jakub Zelenka)

--001a11c2bd841c141204ebf2d59a
Content-Type: text/plain; charset=ISO-8859-1

On Mon, Nov 18, 2013 at 10:43 PM, Anatol Belski <ab@php.net> wrote:

> Hi,
>
> the branch with size_t for string length and 64 bit integer replacement
> for long datatype was brought so far. This branch is based on the one
> started by Anthony Ferrara.
>
> Compiled with --disable-all --enable-cli this functionality is already
> available. Except of a couple of edge cases, the tests pass on both 64 bit
> Windows and Linux. The implementation is ready as a solid base for the
> further porting. There are several new macros and typedefs to handle 64
> bit compatibility. All those are placeholders which can be easily renamed
> later, if needed. There is a wiki page indicating the current progress and
> containing quick start instructions:
>
> https://wiki.php.net/rfc/string-size_t/progress
>
> As the base does exist now, I'd like to call the maintainers and
> developers to participate on further porting of the core extensions and
> SAPIs. Many of those should be easy to convert. Any reviews and comments
> on what is done are of course welcome, too.
>
> The new era of PHP is coming, do your part! :)
>
>
Hi,

I have been playing with openssl a bit and made it work with this
configuration:

--disable-all --enable-cli --enable-debug --with-openssl

The commit is here

https://github.com/bukka/php-src/commit/215811e3fdb7b4f2786576851c8687c6249c4725

It's just an initial work but it works fine for all tests. However there
are lots of issues that need to be properly tested. I made notes about all
possible issues that could be a problem:

https://gist.github.com/bukka/7617548

Lots of them are just possible loss of data that won't be really
problematic but testing is required anyway IMHO. But some issues could be a
problem and they need a proper testing.

I currently work on my php-crypto ext that I plan to propose for PECL soon.
So I will be doing testing for more versions of OpenSSL anyway. I could
prepare some tests for edge cases and do it together though.

Let me know what you think about the patch!

Thanks

Regards

Jakub

--001a11c2bd841c141204ebf2d59a--