Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:70245
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.45 as permitted sender)
Content-Type: text/plain; charset=koi8-r; format=flowed; delsp=yes
To: "internals@lists.php.net" <internals@lists.php.net>, "Stas Malyshev"
 <smalyshev@sugarcrm.com>
References: <op.w56kvihzc9evq2@nikita2206-n56vj>
 <op.w6uh9j0ic9evq2@nikita2206-n56vj> <528D074F.5010206@sugarcrm.com>
Date: Thu, 21 Nov 2013 00:16:30 +0400
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Message-ID: <op.w6u6lscic9evq2@nikita-pc>
In-Reply-To: <528D074F.5010206@sugarcrm.com>
User-Agent: Opera Mail/12.16 (Win32)
Subject: Re: [PHP-DEV] Re: array_unique optional compare-callback proposal
From: inefedor@gmail.com ("Nikita Nefedov")

On Wed, 20 Nov 2013 23:02:39 +0400, Stas Malyshev <smalyshev@sugarcrm.com>  
wrote:

> Hi!
>
>>> $newArray = array_unique($a, SORT_USERDEFINED, function ($a, $b) {
>>>      return $a->getWrappedObject()->getIdentity() -
>>> $b->getWrappedObject()->getIdentity();
>>> });
>>>
>>>
>>> Actually my problem was a little different but you get the idea... And  
>>> I
>>> think there will be even more usecases for this.
>
> What I notice here is that if we add SORT_USERDEFINED, we need to add it
> to all other sorts, otherwise it would be inconsistent - why SORT_*
> works for all sort functions but SORT_USERDEFINED works only for one of
> them? And that opens a bit of a can of worms because for many array
> functions this already exists as u* aliases - usort, array_udiff, etc.
>

Hi,

Actually I have considered implementing another function for this, but  
there were two things I didn't like: name of the function array_uunique -  
it just sounds bad and it will cause a lot of mistakes (when you use  
autocomplete especially), and second - this function will have a lot of  
copy-pasted stuff from array_unique source (though this is somewhat  
solvable if I create another function with logic (not exposed to  
userland)).

But what do you think about this signature then:
array_unique(array $array, int $flag);
array_unique(array $array, Callable $callback);

This is, again, seems inconsistent with all other array_u* functions, but  
calling a function 'array_uunique' is just something I would prefer to  
avoid.